Switch payloads of new phase 2 tau ID to GT #31866

swozniewski · 2020-10-19T21:53:41Z

PR description:

Changes payload labels of the recently added phase 2 tau ID and anti-ele ID such that payloads are loaded via Global Tag.
Builds on top of PR #31470 which is fully signed but not yet merged.
Requires GT 112X_mcRun4_realistic_Candidate_2020_09_17_13_57_14

PR validation:

ran miniAOD sequence for phase2 with payloads loaded via the named GT
code-checks and format pass
unit tests pass
limited matrix tests pass all but three. After adding above GT these do not fail due to missing payload anymore but I get an error of category 'DataCorrupt' from SiPixelRecHitConverter for unknown reasons, but does not seem to be related to this PR.

cmsbuild · 2020-10-19T21:54:05Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-19T21:59:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31866/19227

This PR adds an extra 136KB to repository
Found files with invalid states:
- CommonTools/Egamma/plugins/ElectronCollectionMerger.cc:
  - Added: bf70fdd
  - Modified: 114ed44
  - Deleted: 07f23dc
- RecoTauTag/RecoTau/python/PATTauDiscriminationAgainstElectronMVA6_cff.py:
  - Added: 4cb08e8
  - Modified: 03b8420
  - Deleted: f260dd1
- CommonTools/Egamma/plugins/BuildFile.xml:
  - Added: bf70fdd
  - Deleted: 07f23dc
- RecoTauTag/RecoTau/python/PFRecoTauDiscriminationAgainstElectronMVA6_cff.py:
  - Added: 4cb08e8
  - Modified: 03b8420, 166a276
  - Deleted: f260dd1
There are other open Pull requests which might conflict with changes you have proposed:
- File CommonTools/RecoAlgos/plugins/ElectronCollectionMerger.cc modified in PR(s): Add anti-electron tauID for phase2 #31470
- File PhysicsTools/PatAlgos/plugins/PATTauProducer.cc modified in PR(s): Add anti-electron tauID for phase2 #31470
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Add anti-electron tauID for phase2 #31470, Sub-event aware genJet and parton matching for HI miniAOD #31698
- File RecoTauTag/Configuration/python/loadRecoTauTagMVAsFromPrepDB_cfi.py modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/BuildFile.xml modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/interface/AntiElectronDeadECAL.h modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/interface/AntiElectronIDMVA6.h modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/interface/PositionAtECalEntranceComputer.h modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/plugins/TauDiscriminationAgainstElectronDeadECAL.cc modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/plugins/TauDiscriminationAgainstElectronMVA6.cc modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/python/PATTauDiscriminationAgainstElectronMVA6Phase2_cff.py modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/python/PFRecoTauDiscriminationAgainstElectronMVA6Phase2_cff.py modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/python/tauDiscriminationAgainstElectronMVA6Phase2_mvaDefs_cff.py modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/python/tools/runTauIdMVA.py modified in PR(s): Add anti-electron tauID for phase2 #31470, Change DeepTauID modules so they can also process RECO input for HLT purposes #31744
- File RecoTauTag/RecoTau/src/AntiElectronDeadECAL.cc modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/src/AntiElectronIDMVA6.cc modified in PR(s): Add anti-electron tauID for phase2 #31470
- File RecoTauTag/RecoTau/src/PositionAtECalEntranceComputer.cc modified in PR(s): Add anti-electron tauID for phase2 #31470

cmsbuild · 2020-10-19T22:00:04Z

A new Pull Request was created by @swozniewski for master.

It involves the following packages:

CommonTools/RecoAlgos
PhysicsTools/PatAlgos
RecoTauTag/Configuration
RecoTauTag/RecoTau

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @abbiendi, @emilbols, @ahinzmann, @seemasharmafnal, @mmarionncern, @makortel, @smoortga, @jhgoh, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @clelange, @riga, @JyothsnaKomaragiri, @hatakeyamak, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-10-20T02:10:32Z

Requires GT 112X_mcRun4_realistic_Candidate_2020_09_17_13_57_14

@cms-sw/alca-l2 please clarify on plans for when the GT will be available in the autoCond

Builds on top of PR #31470 which is fully signed but not yet merged.

a rebase is needed now that it's actually merged

christopheralanwest · 2020-10-20T02:45:51Z

Requires GT 112X_mcRun4_realistic_Candidate_2020_09_17_13_57_14

@cms-sw/alca-l2 please clarify on plans for when the GT will be available in the autoCond

The GT candidate listed above was not built on top of the latest content of the 112X_mcRun4_realistic_Queue. I created a GT 112X_mcRun4_realistic_v4 that remedies this problem. The diff with respect to the candidate consists of tags that are not relevant for this PR:

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun4_realistic_Candidate_2020_09_17_13_57_14/112X_mcRun4_realistic_v4

Could you change v3 to v4 here:

https://github.com/cms-sw/cmssw/blob/master/Configuration/AlCa/python/autoCond.py#L84

and include the changes in this PR?

cmsbuild · 2020-10-20T10:22:55Z

The code-checks are being triggered in jenkins.

swozniewski · 2020-10-20T10:23:56Z

Ok, I rebased the branch and updated the version in autoCond

cmsbuild · 2020-10-20T10:29:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31866/19242

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoTauTag/RecoTau/python/tools/runTauIdMVA.py modified in PR(s): Change DeepTauID modules so they can also process RECO input for HLT purposes #31744

cmsbuild · 2020-10-20T10:29:24Z

Pull request #31866 was updated. @perrotta, @yuanchao, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @jpata, @pohsun can you please check and sign again.

christopheralanwest · 2020-10-20T10:38:02Z

please test

cmsbuild · 2020-10-20T10:38:25Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-19-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10124/console Started: 2020/10/20 13:55

perrotta · 2020-10-23T11:12:47Z

please test

cmsbuild · 2020-10-23T11:13:12Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-23-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10238/console Started: 2020/10/23 13:15

cmsbuild · 2020-10-23T12:39:31Z

+1
Tested at: bd1cc46
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50b446/10238/summary.html
CMSSW: CMSSW_11_2_X_2020-10-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-23T12:39:34Z

Comparison job queued.

cmsbuild · 2020-10-23T13:58:39Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50b446/10238/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544110
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2544078
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

kpedro88 · 2020-10-23T20:11:28Z

+upgrade

perrotta · 2020-10-26T14:06:28Z

+1

Payloads for Phase2 tau-ID are taken from the GT, as intended
Jenkins tests pass and show no differences wrt the baseline

christopheralanwest · 2020-10-26T14:20:36Z

+alca

cmsbuild · 2020-10-26T14:20:55Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-10-26T14:43:45Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Oct 19, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 19, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 19, 2020

Sebastian Wozniewski added 2 commits October 20, 2020 11:07

switch to GT for payloads of new phaseII IDs

181b496

update version of phase2_realistic autoCond

a352614

swozniewski force-pushed the CMSSW_11_2_X_tau-pog_phase2-ID-to-GT branch from 5d3d618 to a352614 Compare October 20, 2020 10:22

cmsbuild added alca-pending code-checks-pending and removed analysis-pending code-checks-approved labels Oct 20, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 20, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 23, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 23, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 23, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 23, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 26, 2020

cmsbuild removed alca-pending pending-signatures labels Oct 26, 2020

cmsbuild added alca-approved fully-signed labels Oct 26, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 26, 2020

cmsbuild merged commit 8e82638 into cms-sw:master Oct 26, 2020

This was referenced Oct 27, 2020

Adding vertex recovery step for 2018 heavy ion miniAOD production. #31676

Merged

[Do not merge] Just to test cms-bot #31945

Closed

mbluj deleted the CMSSW_11_2_X_tau-pog_phase2-ID-to-GT branch October 10, 2023 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch payloads of new phase 2 tau ID to GT #31866

Switch payloads of new phase 2 tau ID to GT #31866

swozniewski commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

slava77 commented Oct 20, 2020

christopheralanwest commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

swozniewski commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

christopheralanwest commented Oct 20, 2020

cmsbuild commented Oct 20, 2020 •

edited

Loading

perrotta commented Oct 23, 2020

cmsbuild commented Oct 23, 2020 •

edited

Loading

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

kpedro88 commented Oct 23, 2020

perrotta commented Oct 26, 2020

christopheralanwest commented Oct 26, 2020

cmsbuild commented Oct 26, 2020

qliphy commented Oct 26, 2020

Switch payloads of new phase 2 tau ID to GT #31866

Switch payloads of new phase 2 tau ID to GT #31866

Conversation

swozniewski commented Oct 19, 2020

PR description:

PR validation:

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

slava77 commented Oct 20, 2020

christopheralanwest commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

swozniewski commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

christopheralanwest commented Oct 20, 2020

cmsbuild commented Oct 20, 2020 • edited Loading

perrotta commented Oct 23, 2020

cmsbuild commented Oct 23, 2020 • edited Loading

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

kpedro88 commented Oct 23, 2020

perrotta commented Oct 26, 2020

christopheralanwest commented Oct 26, 2020

cmsbuild commented Oct 26, 2020

qliphy commented Oct 26, 2020

cmsbuild commented Oct 20, 2020 •

edited

Loading

cmsbuild commented Oct 23, 2020 •

edited

Loading