-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD geometry: update tests for DD4hep #32111
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32111/19761
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Geometry/MTDCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@kpedro88 @silviodonato @qliphy do you see a problem with this PR? |
@fabiocos is it necessary to retain non-MTD subdetectors as commented-out lines in the xml, rather than removing them completely? |
@kpedro88 this is for simplicity to compare in a straightforward way with the original from which this is derived. It is not strictly speaking necessary, it makes the comparison a bit simpler, and as it is a test configuration that will go as soon as dd4hep migration is completed I do not think it should create problems |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR contains a collection of updates to support the validation of DD4hep in standard workflows, beyond the pure dump of geometry objects:
update and add mtd-devoted DD4hep ideal configurations based now on the complete ones, commenting all subdetectors but MTD and using an ad-hoc empty tracker mother volume;
update the DDD ideal geometry dump, to get back namespaces in the path dump (for easier comparison with DD4hep);
add a customization fragment to
SimG4Core/PrintGeomInfo
to easily use in any configuration thePrintGeomInfo
class (the existing code is more an ad-hoc standalone configuration).PR validation:
By manually adapting the existing DD4hep test workflows to use the MTD-only geometry, the step1 may run, cross MTD (as verified with
SteppingVerbosity
) and produce SimHits within MTD in MtdSD, as visualized withrunSimHitCaloHitDumper_cfg.py
.The issues causing crashes within step1 for Phase2 test workflows are not due to MTD according to this check, they come from the geometry building in
DD4hep_DDG4Builder
when the whole configuration is used.