adding converter for Basic to PF Jets

[clint-richardson]

As the title suggests this is to add a plugin that will convert reco::BasicJets to reco::PFJets. Such a converter is needed in order to work with Basic Jets using HLTFilters.

[cmsbuild]

A new Pull Request was created by @clint-richardson (Clint Richardson) for CMSSW_7_1_X.

adding converter for Basic to PF Jets

It involves the following packages:

RecoJets/JetProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@yslai, @TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-08-0200/src/RecoJets/JetProducers/src/PileupJetIdAlgo.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-08-0200/src/RecoJets/JetProducers/src/VirtualJetProducerHelper.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-08-0200/src/RecoJets/JetProducers/test/test-large-voronoi-area.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-08-0200/src/RecoJets/JetProducers/plugins/BasicToPFJet.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-08-0200/src/RecoJets/JetProducers/plugins/BoostedTauSeedsProducer.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-08-0200/src/RecoJets/JetProducers/plugins/BasicToPFJet.cc:21:39: fatal error: ../interface/BasicToPFJet.h: No such file or directory
 #include "../interface/BasicToPFJet.h"
                                       ^
compilation terminated.
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-08-0200/src/RecoJets/JetProducers/plugins/BasicToPFJet.cc:21:39: fatal error: ../interface/BasicToPFJet.h: No such file or directory
 #include "../interface/BasicToPFJet.h"


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3220/807/summary.html

[slava77]

please remove "$Id$", CVS-related special

[slava77]

-1

see comments from the code review

[clint-richardson]

Hi @slava77

I've attempted to comply with your requests. Can you let me know what else I'm missing? I didn't understand the comment that was 'why not start here from the beginning' - could you explain it to me? Thanks,
-Clint

[clint-richardson]

Hi @slava77

I've made the change

Best,
-Clint

[cmsbuild]

Pull request #3220 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3220/831/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3220/831/summary.html

[slava77]

+1

for #3220 8fa4ca6

tested in
CMSSW_7_1_X_2014-04-08-0200 (test area sign338) in a combination of pulls 3233 and 3220.
No changes observed, none expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?