Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCAL] Using single particle in closeby configurations #32263

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

apsallid
Copy link
Contributor

PR description:

We are reducing the number of particles produced with the closeby particle gun to one, decreasing unnecessary complexity in the regular validation campaigns.

PR validation:

We checked that the validation can be performed without any issue.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport.

@rovere @felicepantaleo @ebrondol @lecriste

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32263/20040

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apsallid for master.

It involves the following packages:

Configuration/Generator

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@agrohsje
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 25, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1
Tested at: bc18939
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d24dc/11022/summary.html
CMSSW: CMSSW_11_2_X_2020-11-24-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d24dc/11022/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2274 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2963516
  • DQMHistoTests: Total failures: 54292
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2909202
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 158 log files, 34 edm output root files, 37 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Nov 25, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants