Access Conditions DB for HCAL Pulse Filtering Weights

[JHiltbrand]

PR description:

This PR is a follow-up to #31661, which added functionality to do pulse filtering targeting OOT PU subtraction. This follow-up PR adds interfacing with the conditions database. Filter weights can be obtained from HcalTPChannelParameter object. By default, nothing changes compared to historic behavior. Two python configuration "switches" useDBweightsAndFilterHE_ and useDBweightsAndFilterHB_ have been added to the hcaltpdigi_cfi.py and hcaltpdigi_cff.py files. Activating these switches will configure to use a specific filter and obtain the weights from the conditions database.

PR validation:

In the default configuration, with the new python switches set to false, no changes are observed in HCAL TP properties.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32717/20851

• This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32717/20851/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32717/20851/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32717/20852

• This PR adds an extra 52KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32717/20852/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32717/20852/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32717/20855

• This PR adds an extra 84KB to repository

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32717/21588

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • Configuration/Eras/python/Modifier_run3_HE_cff.py:
    • Added: f98da57
    • Deleted: 238ab46

[cmsbuild]

Pull request #32717 was updated. @malbouis, @civanch, @Dr15Jones, @makortel, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @rekovic, @yuanchao, @tlampen, @pohsun, @cecilecaillol, @francescobrivio can you please check and sign again.

[christopheralanwest]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0afe5b/13521/summary.html
COMMIT: 238ab46
CMSSW: CMSSW_11_3_X_2021-03-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32717/13521/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2635087
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2635058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files

[rekovic]

+1

[cvuosalo]

+1

[silviodonato]

@cms-sw/alca-l2 do you have further comments?

[francescobrivio]

+alca

• Deprecated eventSetup.get<>() calls fixed
• Failures in WF tests not related to this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1