Run3-gex49 Correct the spellings in the scripts in CondTools/Geometry #32745

bsunanda · 2021-01-26T15:48:31Z

PR description:

Correct the spellings in the scripts in CondTools/Geometry

PR validation:

Tested using runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-01-26T15:55:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32745/20897

This PR adds an extra 16KB to repository

cmsbuild · 2021-01-26T15:55:35Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

CondTools/Geometry

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-01-26T15:57:46Z

@cmsbuild Please test

bsunanda · 2021-01-26T15:57:59Z

@cvuosalo Please check this

cmsbuild · 2021-01-26T17:50:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32745/20899

This PR adds an extra 16KB to repository

cmsbuild · 2021-01-26T17:51:14Z

Pull request #32745 was updated. @ggovi, @cmsbuild can you please check and sign again.

bsunanda · 2021-01-26T19:02:56Z

@cmsbuild Please test

cvuosalo · 2021-01-26T19:46:31Z

@bsunanda The PR description says these scripts were tested with runTheMatrix.py. That test does not touch these scripts. They have to be run individually. For example:

cd  CondTools/Geometry/test
/bin/cp writehelpers/* .
./createExtended2017Plan1Payloads.sh 113YV99

cmsbuild · 2021-01-26T21:29:34Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-535b11/12551/summary.html
COMMIT: 4d259b6
CMSSW: CMSSW_11_3_X_2021-01-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32745/12551/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

No significant changes to the logs found
Reco comparison results: 1096 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2716596
DQMHistoTests: Total failures: 3611
DQMHistoTests: Total nulls: 19
DQMHistoTests: Total successes: 2712944
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -45.703 KiB( 36 files compared)
DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
Checked 156 log files, 37 edm output root files, 37 DQM output files

cmsbuild · 2021-01-26T21:29:35Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-535b11/12551/summary.html
COMMIT: 4d259b6
CMSSW: CMSSW_11_3_X_2021-01-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32745/12551/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

No significant changes to the logs found
Reco comparison results: 1096 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2716596
DQMHistoTests: Total failures: 3611
DQMHistoTests: Total nulls: 19
DQMHistoTests: Total successes: 2712944
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -45.703 KiB( 36 files compared)
DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
Checked 156 log files, 37 edm output root files, 37 DQM output files

cvuosalo · 2021-01-26T22:56:59Z

@bsunanda Search for "Perecent" in createExtended2017Plan1Payloads.sh. There are three misspellings that need to be corrected. Also, TrackerGeometricDetESModule has to be deleted from CondTools/Geometry/test/writehelpers/geometryExtended2017_writer.py and CondTools/Geometry/test/writehelpers/geometryExtended2018_writer.py.

createExtended2017Plan1Payloads.sh and createExtended2018Payloads.sh have not been used for quite some time, and they are currently non-functional, so you are opening a can of worms by touching them. They would be used to create new geometry DB payloads for Run 2, but there is currently no use case for this task.

You might want to drop createExtended2017Plan1Payloads.sh and createExtended2018Payloads.sh from this PR, and instead write an issue describing the problems with them that need to be fixed (what I mentioned above). If you keep them in this PR, you will need to debug and test them.

cvuosalo · 2021-01-26T22:58:08Z

@bsunanda createExtended2021Payloads.sh looks good to me. It can stay in this PR. You should test it yourself to verify that it is working.

ggovi · 2021-02-01T16:09:37Z

+1

cmsbuild · 2021-02-01T16:09:59Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-02-01T16:16:00Z

please test

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-535b11/12551/summary.html
COMMIT: 4d259b6
CMSSW: CMSSW_11_3_X_2021-01-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32745/12551/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:
* No significant changes to the logs found

* Reco comparison results: 1096 differences found in the comparisons

* DQMHistoTests: Total files compared: 37

* DQMHistoTests: Total histograms compared: 2716596

* DQMHistoTests: Total failures: 3611

* DQMHistoTests: Total nulls: 19

* DQMHistoTests: Total successes: 2712944

* DQMHistoTests: Total skipped: 22

* DQMHistoTests: Total Missing objects: 0

* DQMHistoSizes: Histogram memory added: -45.703 KiB( 36 files compared)

* DQMHistoSizes: changed ( 140.53 ): -44.531 KiB      Hcal/DigiRunHarvesting

* DQMHistoSizes: changed ( 140.53 ): -1.172 KiB       RPC/DCSInfo

* Checked 156 log files, 37 edm output root files, 37 DQM output files

I'm surprised to see so many changes in 140.53 RunHI2011+RECOHID11+HARVESTDHI.
@bsunanda @cvuosalo @ggovi did you expect it? Perhaps it is uncorrelated to this PR therefore I started the test again

cvuosalo · 2021-02-01T17:39:17Z

@silviodonato The scripts in this PR are not exercised by any PR test, so the PR comparison differences have nothing to do with this PR.
In fact, two scripts in this PR are not even working:

CondTools/Geometry/test/writehelpers/createExtended2017Plan1Payloads.sh
CondTools/Geometry/test/writehelpers/createExtended2018Payloads.sh

I don't think it is recommended practice to approve PRs with non-working scripts. At the very least, prominent "FIXME" comments should be added to the two scripts.

silviodonato · 2021-02-02T08:13:41Z

please test

silviodonato · 2021-02-02T12:23:50Z

@smuzaffar are the tests running? I see " cms/32745/slc7_amd64_gcc900/comparison Pending — Waiting for tests to start "

smuzaffar · 2021-02-02T13:00:51Z

@silviodonato , yes tests are running, jenkins is still under heavy load after yesterday's network issues.

cmsbuild · 2021-02-02T15:56:01Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-535b11/12639/summary.html
COMMIT: 4d259b6
CMSSW: CMSSW_11_3_X_2021-02-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32745/12639/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2752926
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2752899
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

silviodonato · 2021-02-03T11:47:14Z

+1

Correct the spellings in the scripts

05db23c

cmsbuild added this to the CMSSW_11_3_X milestone Jan 26, 2021

cmsbuild added code-checks-pending db-pending orp-pending pending-signatures tests-pending labels Jan 26, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 26, 2021

cmsbuild added tests-started and removed tests-pending labels Jan 26, 2021

Correct the scripts

4d259b6

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Jan 26, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 26, 2021

cmsbuild added tests-started and removed tests-pending labels Jan 26, 2021

cmsbuild added tests-approved and removed tests-started labels Jan 26, 2021

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Feb 1, 2021

cmsbuild added tests-started and removed tests-approved labels Feb 1, 2021

cmsbuild added tests-approved and removed tests-started labels Feb 2, 2021

cmsbuild added orp-approved and removed orp-pending labels Feb 3, 2021

cmsbuild merged commit 18bc30c into cms-sw:master Feb 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-gex49 Correct the spellings in the scripts in CondTools/Geometry #32745

Run3-gex49 Correct the spellings in the scripts in CondTools/Geometry #32745

bsunanda commented Jan 26, 2021

cmsbuild commented Jan 26, 2021

cmsbuild commented Jan 26, 2021

bsunanda commented Jan 26, 2021

bsunanda commented Jan 26, 2021

cmsbuild commented Jan 26, 2021

cmsbuild commented Jan 26, 2021

bsunanda commented Jan 26, 2021

cvuosalo commented Jan 26, 2021

cmsbuild commented Jan 26, 2021

cmsbuild commented Jan 26, 2021

cvuosalo commented Jan 26, 2021

cvuosalo commented Jan 26, 2021

ggovi commented Feb 1, 2021

cmsbuild commented Feb 1, 2021

silviodonato commented Feb 1, 2021

Comparison Summary

cvuosalo commented Feb 1, 2021

silviodonato commented Feb 2, 2021

silviodonato commented Feb 2, 2021

smuzaffar commented Feb 2, 2021

cmsbuild commented Feb 2, 2021

silviodonato commented Feb 3, 2021

Run3-gex49 Correct the spellings in the scripts in CondTools/Geometry #32745

Run3-gex49 Correct the spellings in the scripts in CondTools/Geometry #32745

Conversation

bsunanda commented Jan 26, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jan 26, 2021

cmsbuild commented Jan 26, 2021

bsunanda commented Jan 26, 2021

bsunanda commented Jan 26, 2021

cmsbuild commented Jan 26, 2021

cmsbuild commented Jan 26, 2021

bsunanda commented Jan 26, 2021

cvuosalo commented Jan 26, 2021

cmsbuild commented Jan 26, 2021

Comparison Summary

cmsbuild commented Jan 26, 2021

Comparison Summary

cvuosalo commented Jan 26, 2021

cvuosalo commented Jan 26, 2021

ggovi commented Feb 1, 2021

cmsbuild commented Feb 1, 2021

silviodonato commented Feb 1, 2021

Comparison Summary

cvuosalo commented Feb 1, 2021

silviodonato commented Feb 2, 2021

silviodonato commented Feb 2, 2021

smuzaffar commented Feb 2, 2021

cmsbuild commented Feb 2, 2021

Comparison Summary

silviodonato commented Feb 3, 2021