Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DQMOffline/Alignment and CondTools/DQM to esConsumes #32851

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 9, 2021

PR description:

Title says it all.

  • migrated to esConsumes subsystem DQMOffline/Alignment
  • migrated to esConsumes subsystem CondTools/DQM
  • analyzers in CondTools/DQM have been modernized

Part of #31061

PR validation:

Compiles + run scramv1 b runtests

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport is needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32851/21069

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondTools/DQM
DQMOffline/Alignment

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @ggovi, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 9, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45c865/12780/summary.html
COMMIT: bf71d2f
CMSSW: CMSSW_11_3_X_2021-02-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32851/12780/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2751765
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2751730
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 9, 2021

+1

@ggovi
Copy link
Contributor

ggovi commented Feb 12, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 12, 2021

+1

@cmsbuild cmsbuild merged commit e3f75e8 into cms-sw:master Feb 12, 2021
@mmusich mmusich deleted the moreESConsmumeMigration_0 branch September 30, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants