Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove PPS workflows 11725.0 and 11925.0 #33020

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Conversation

qliphy
Copy link
Contributor

@qliphy qliphy commented Mar 1, 2021

PR description:

Missing GEN-SIM input file for 11725.0 and 11925.0 is causing IB/PR test failures.
This PR is to remove PPS workflows before PdmV updates GS string in 11_3_X, see more in
#33010

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@qliphy
Copy link
Contributor Author

qliphy commented Mar 1, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33020/21306

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

A new Pull Request was created by @qliphy (Qiang Li) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @srimanob, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor Author

qliphy commented Mar 1, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33020/21308

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

Pull request #33020 was updated. @chayanit, @srimanob, @wajidalikhan, @kpedro88, @jordan-martins can you please check and sign again.

@silviodonato
Copy link
Contributor

please test

@silviodonato
Copy link
Contributor

(partial revert of #32983)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2118e8/13153/summary.html
COMMIT: 6bcb48f
CMSSW: CMSSW_11_3_X_2021-02-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33020/13153/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2750952
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@chayanit
Copy link

chayanit commented Mar 1, 2021

+1

@qliphy
Copy link
Contributor Author

qliphy commented Mar 1, 2021

@cms-sw/upgrade-l2 Would you please have a check and sign if no problem? This is to fix IB/PR issues.

@srimanob
Copy link
Contributor

srimanob commented Mar 1, 2021

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor Author

qliphy commented Mar 1, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants