Fixed problem handling pass by value arguments. #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing all the arguments to rvalue references failed to handle arguments which are passed by value. Instead, we keep the arguments as their regular type and just use std::forward<> to move the values to the constructors.
|
The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core @cms-git-visualization, @cms-git-core, @cms-git-geometry |
ghost
assigned 
|
Hi, I took these changes on top of CMSSW_7_0_X_2013-08-14-1400, I ran the unit tests and RelVals, all tests passed. You can see the logs here: |
ktf
added a commit
that referenced
this pull request
Aug 16, 2013
Fixed problem handling pass by value arguments.
ktf
added a commit
that referenced
this pull request
Jan 21, 2014
Updated frontier_client to version 2.8.9
makortel
pushed a commit
to makortel/cmssw
that referenced
this pull request
Apr 22, 2015
deprecate-local and --tag options for release build
gpetruc
added a commit
to gpetruc/cmssw
that referenced
this pull request
May 7, 2015
…Heppy Heppy: enhancements to JSON, PileUp, and QG analyzers; new feature for batchmanager
cvernier
pushed a commit
to cvernier/cmssw
that referenced
this pull request
Feb 3, 2016
Vhbb heppy76 x post pre run
emanca
pushed a commit
to emanca/cmssw
that referenced
this pull request
May 8, 2019
Read LHE reweighting automatically
slava77
pushed a commit
to slava77/cmssw
that referenced
this pull request
Oct 9, 2021
adjust dupl. cleaning for pixel pair iteration
ttrk
added a commit
to ttrk/cmssw
that referenced
this pull request
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing all the arguments to rvalue references failed to handle arguments which are passed by value.
Instead, we keep the arguments as their regular type and just use std::forward<> to move the values
to the constructors.
This is a rebase of pull #319.