Run4-278X Bug fix for allowing more scintillator cells beyond Digi

[bsunanda]

PR description:

Bug fix for allowing more scintillator cells to appear after Digi and Reco

PR validation:

Tested using runTheMatrix workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33173/21573

• This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33173/21573/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33173/21573/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33173/21574

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/CaloTopology
Geometry/HGCalCommonData
Geometry/HGCalGeometry
SimG4CMS/Calo

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7fc58/13493/summary.html
COMMIT: c0946e2
CMSSW: CMSSW_11_3_X_2021-03-14-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33173/13493/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6030 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2635087
• DQMHistoTests: Total failures: 64730
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2570334
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files

[srimanob]

Urgent

FYI @qliphy @silviodonato

[cvuosalo]

+1

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1