-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate RecoParticleFlow/PFTracking to esConsumes #33367
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33367/21956
|
A new Pull Request was created by @marksan87 (Mark Saunders) for master. It involves the following packages: RecoParticleFlow/PFTracking @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
@cmsbuild please test I can't find the previous test in jenkins, seems stuck/lost. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-766e47/14124/summary.html CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-766e47/14124/llvm-analysis/cmsclangtidy.txt for details. Comparison SummarySummary:
|
No unexpected reco changes detected. Code changes look good, a minor comment inline. Looks like there's another
|
LogDebug("HGCalTrackCollectionProducer") | ||
<< " HGCalTrackCollectionProducer::HGCalTrackCollectionProducer " << std::endl; | ||
|
||
const edm::ParameterSet& geoconf = iConfig.getParameterSet("hgcalGeometryNames"); | ||
hgc_names_[0] = geoconf.getParameter<std::string>("HGC_ECAL"); | ||
for (unsigned i = 0; i < hgcGeometryTokens_.size(); i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for (unsigned i = 0; i < hgcGeometryTokens_.size(); i++) { | |
for (const auto i : hgcGeometryTokens_) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, I'm a little confused why you need an std::array
of length 1 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This format was kept to allow for future extrapolation to HGCal hadronic sections.
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33367/21995
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33367/21998
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-766e47/14173/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
+reconstruction
Thanks for this! |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Migration of
RecoParticleFlow/PFTracking
package to esConsumes to address #31061PR validation:
Run standard limited matrix evaluation
runTheMatrix.py -l limited -j 8 --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport
@hatakeyamak