Open and close conditions file after TFileAdaptor is enabled #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X. Open and close conditions file after TFileAdaptor is enabled It involves the following packages: FWCore/Framework @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
ktf
added a commit
that referenced
this pull request
Apr 15, 2014
ROOT6 -- Open and close conditions file after TFileAdaptor is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a workaround already in place that opens and closes a ROOT/EDM file of conditions data at the beginning of a cmsRun job, before TFileAdaptor has been enabled. This causes a fatal error with new ROOT6 code (not yet in the IB) that unloads plugins when TFileAdaptor is later enabled.
This fix moves the opening and closing of the conditions data file to after TFileAdaptor is enabled, thereby avioding the problem.
Please merge this promptly unless there are issues.