-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertex smearing and beamspot for PP ref UL MC #33504
Vertex smearing and beamspot for PP ref UL MC #33504
Conversation
A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_10_6_X. It involves the following packages: Configuration/AlCa @malbouis, @civanch, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @christopheralanwest, @srimanob, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @mdhildreth, @tlampen, @qliphy, @pohsun, @davidlange6, @fabiocos, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@mandrenguyen , you need submit also PR for the master, as minimum, new beamspot. |
@civanch As I mentioned in the comments, as far as I can see, there is no GT for the pp reference run in releases newer than 10_X_Y. Therefore, I cannot implement a workflow with a compatible vertex smearing / GT pair. |
@cms-sw/alca-l2 What is the plan for master? Thanks. |
We discussed this among AlCaDB and decided to make a forward port to master also. The general approach is that we maintain GTs for all workflows on which there might be a production in the future, even if it is unlikely (there are e.g. Run1 GTs). |
Please test workflow 149 |
Thanks @tlampen @cms-sw/alca-l2 |
-1 Failed Tests: RelVals RelVals
|
Pull request #33504 was updated. @malbouis, @civanch, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @christopheralanwest, @srimanob, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @mdhildreth, @tlampen, @qliphy, @pohsun, @davidlange6, @fabiocos, @francescobrivio can you please check and sign again. |
@srimanob Can you run the test again? I had forgotten one file. |
test parameters |
please test |
+alca
|
+1 |
+1 |
It seems the last test does not trigger workflow 149. |
please test workflow 149 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1eaec/15002/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade This PR is to add new vertex smearing and BS for PP-REF of 2017G. With the new GT, the target test workflow 149 runs fine. |
+operations |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
We are preparing for the UL MC of 2017G, the 5 TeV pp reference dataset.
A GT was prepared by Alca:
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4390/1/1/1/1/1/1/1/1/1/1/3.html
They have requested that it be tested in a relval workflow, which is the goal of this PR.
It turns out that the final vertex smearing used for the processing in 94X ( #28573 ), was never propagated to 106X, so this is also included in this PR.
The relval workflow implementing both the updated vertex smearing and beamspot is 149.
PR validation:
Workflow 149 was tested.
if this PR is a backport please specify the original PR and why you need to backport that PR:
EDIT:
This PR is now a backport. The PP ref GTs have been forwarded ported and added to the autoconds in #33655
@christopheralanwest