Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex smearing and beamspot for PP ref UL MC #33504

Merged
merged 2 commits into from May 17, 2021

Conversation

mandrenguyen
Copy link
Contributor

@mandrenguyen mandrenguyen commented Apr 22, 2021

PR description:

We are preparing for the UL MC of 2017G, the 5 TeV pp reference dataset.
A GT was prepared by Alca:
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4390/1/1/1/1/1/1/1/1/1/1/3.html

They have requested that it be tested in a relval workflow, which is the goal of this PR.
It turns out that the final vertex smearing used for the processing in 94X ( #28573 ), was never propagated to 106X, so this is also included in this PR.

The relval workflow implementing both the updated vertex smearing and beamspot is 149.

PR validation:

Workflow 149 was tested.

if this PR is a backport please specify the original PR and why you need to backport that PR:

EDIT:
This PR is now a backport. The PP ref GTs have been forwarded ported and added to the autoconds in #33655

@christopheralanwest

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 22, 2021

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_10_6_X.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation
Configuration/StandardSequences
IOMC/EventVertexGenerators

@malbouis, @civanch, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @christopheralanwest, @srimanob, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @mdhildreth, @tlampen, @qliphy, @pohsun, @davidlange6, @fabiocos, @francescobrivio can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @jan-kaspar, @GiacomoSguazzoni, @tocheng, @VinInn, @Martin-Grunewald, @rovere, @lecriste, @mmusich, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Apr 22, 2021

@mandrenguyen , you need submit also PR for the master, as minimum, new beamspot.

@mandrenguyen
Copy link
Contributor Author

mandrenguyen commented Apr 22, 2021

@civanch As I mentioned in the comments, as far as I can see, there is no GT for the pp reference run in releases newer than 10_X_Y. Therefore, I cannot implement a workflow with a compatible vertex smearing / GT pair.

@srimanob
Copy link
Contributor

@cms-sw/alca-l2 What is the plan for master? Thanks.

@tlampen
Copy link
Contributor

tlampen commented Apr 30, 2021

@cms-sw/alca-l2 What is the plan for master? Thanks.

We discussed this among AlCaDB and decided to make a forward port to master also. The general approach is that we maintain GTs for all workflows on which there might be a production in the future, even if it is unlikely (there are e.g. Run1 GTs).

@srimanob
Copy link
Contributor

Please test workflow 149

@srimanob
Copy link
Contributor

@cms-sw/alca-l2 What is the plan for master? Thanks.

We discussed this among AlCaDB and decided to make a forward port to master also. The general approach is that we maintain GTs for all workflows on which there might be a production in the future, even if it is unlikely (there are e.g. Run1 GTs).

Thanks @tlampen @cms-sw/alca-l2

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1eaec/14738/summary.html
COMMIT: d2f8cc0
CMSSW: CMSSW_10_6_X_2021-04-29-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33504/14738/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 149.0149.0_QCD_Pt_80_120_13_PPREF+QCD_Pt_80_120_13_PPREF+DIGIPPREF2017+RECOPPREF2017+HARVESTPPREF2017/step1_QCD_Pt_80_120_13_PPREF+QCD_Pt_80_120_13_PPREF+DIGIPPREF2017+RECOPPREF2017+HARVESTPPREF2017.log

@cmsbuild
Copy link
Contributor

@mandrenguyen
Copy link
Contributor Author

@srimanob Can you run the test again? I had forgotten one file.

@christopheralanwest
Copy link
Contributor

test parameters
workflow = 149

@christopheralanwest
Copy link
Contributor

please test

@tlampen
Copy link
Contributor

tlampen commented May 11, 2021

+alca

  • backport
  • no differences in comparisons tests (tested with workflow 149)

@chayanit
Copy link

+1

@civanch
Copy link
Contributor

civanch commented May 11, 2021

+1

@srimanob
Copy link
Contributor

It seems the last test does not trigger workflow 149.

@srimanob
Copy link
Contributor

please test workflow 149

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1eaec/15002/summary.html
COMMIT: 5f94d05
CMSSW: CMSSW_10_6_X_2021-05-10-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33504/15002/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c1eaec/149.0_QCD_Pt_80_120_13_PPREF+QCD_Pt_80_120_13_PPREF+DIGIPPREF2017+RECOPPREF2017+HARVESTPPREF2017

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215556
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215219
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

This PR is to add new vertex smearing and BS for PP-REF of 2017G. With the new GT, the target test workflow 149 runs fine.

@silviodonato
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f01a777 into cms-sw:CMSSW_10_6_X May 17, 2021
@mandrenguyen mandrenguyen deleted the fixEmittancePPRef106X branch May 19, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants