SiStripApproximateCluster reduced data format for HI #33546

icali · 2021-04-27T16:22:30Z

PR description:

This PR included the ApproximateClusters data format. The format is useful to reduce the size of HI data because the plan is to replace the strip tracker RAW data with the approximated clusters.

In this PR is included only the data format SiStripApproximateCluster and the producers to convert the SiStripCluster in SiStripApproximateCluster

In a following PR, the changes to the Reco sequence to use the approximated clusters will be added

PR validation:

As of today this PR doesn't require any validation. It was tested locally using the configuration:
RecoLocalTracker/SiStripClusterizer/test/step2_RAW2DIGI_L1Reco_RECO_ApproxClusters.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild · 2021-04-27T16:22:54Z

A new Pull Request was created by @icali (Ivan Amos Cali) for CMSSW_11_3_X.

It involves the following packages:

DataFormats/SiStripCluster
RecoLocalTracker/SiStripClusterizer
SiStripApproximateClusterv2/BuildFile.xml
SiStripApproximateClusterv2/src

The following packages do not have a category, yet:

SiStripApproximateClusterv2/BuildFile.xml
SiStripApproximateClusterv2/src
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @echabert, @pieterdavid, @makortel, @robervalwalsh, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @JanFSchulte, @alesaggio, @felicepantaleo, @gpetruc, @mmusich, @VinInn, @threus, @ebrondol this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

DataFormats/SiStripCluster/interface/SiStripApproximateClusterv1.h

SiStripApproximateClusterv2/BuildFile.xml

SiStripApproximateClusterv2/src/classes.h

cmsbuild · 2021-04-27T16:41:51Z

Pull request #33546 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

mmusich

some other quick comments (waiting for more thorough reco review).

RecoLocalTracker/SiStripClusterizer/interface/SiStripClusters2ApproxClustersv1.h

RecoLocalTracker/SiStripClusterizer/plugins/SiStripClusters2ApproxClustersv1.cc

RecoLocalTracker/SiStripClusterizer/test/step2_RAW2DIGI_L1Reco_RECO_ApproxClusters.py

…proxClustersv1.cc Co-authored-by: Marco Musich <marco.musich@cern.ch>

cmsbuild · 2021-04-27T16:52:15Z

Pull request #33546 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

DataFormats/SiStripCluster/interface/SiStripApproximateClusterv1.h

pieterdavid

Another set of mostly stylistic comments

DataFormats/SiStripCluster/interface/SiStripApproximateClusterv1.h

RecoLocalTracker/SiStripClusterizer/plugins/SiStripClusters2ApproxClustersv1.cc

RecoLocalTracker/SiStripClusterizer/interface/SiStripClusters2ApproxClustersv1.h

RecoLocalTracker/SiStripClusterizer/test/SiStripApproximatedClustersDump.cc

cmsbuild · 2021-04-28T10:32:03Z

Pull request #33546 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

DataFormats/SiStripCluster/interface/SiStripApproximateClusterv1.h

icali · 2021-05-20T18:18:28Z

Sorry for delay in addressing the comments.
I tried to include all the comments received and a presentation on the subject at the tracker DPG was delivered. Also if not the last one, the most conclusive on this specific subject is here: https://indico.cern.ch/event/934815/contributions/4126184/attachments/2159648/3643496/TrackerDPG_20201209.pdf
Please let me know if you have more comments.

cmsbuild · 2021-05-20T18:21:14Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33546/22780

This PR adds an extra 20KB to repository
Found files with invalid states:
- SiStripApproximateClusterv2/BuildFile.xml:
  - Added: 39fe9bb
  - Deleted: 37babea
- DataFormats/SiStripCluster/interface/SiStripApproximateClusterHigherBarycenterRes.h:
  - Added: 89ca71a
  - Deleted: fd310e0
- SiStripApproximateClusterv2/src/classes.h:
  - Added: 39fe9bb
  - Deleted: 37babea
- RecoLocalTracker/SiStripClusterizer/plugins/SiStripClusters2ApproxClustersv1.cc:
  - Added: 39fe9bb
  - Modified: 1a03de5, 1064ace, 11d59de, 6ef4f3c, bbdf8a8
  - Deleted: 89ca71a
- RecoLocalTracker/SiStripClusterizer/python/SiStripClusters2ApproxClustersv1_cfi.py:
  - Added: 39fe9bb
  - Deleted: 6ef4f3c
- RecoLocalTracker/SiStripClusterizer/python/SiStripApproximatedClustersDump_cfi.py:
  - Added: 4616178
  - Modified: 879fc14
  - Deleted: 6ef4f3c
- RecoLocalTracker/SiStripClusterizer/interface/SiStripClusters2ApproxClustersv1.h:
  - Added: b47789c
  - Deleted: 42d38fc
- DataFormats/SiStripCluster/interface/SiStripApproximateClusterv1.h:
  - Added: 39fe9bb
  - Modified: 1064ace, 11d59de
  - Deleted: 89ca71a

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33546/22780/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33546/22780/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-05-20T18:32:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33546/22782

This PR adds an extra 24KB to repository
Found files with invalid states:
- SiStripApproximateClusterv2/BuildFile.xml:
  - Added: 39fe9bb
  - Deleted: 37babea
- DataFormats/SiStripCluster/interface/SiStripApproximateClusterHigherBarycenterRes.h:
  - Added: 89ca71a
  - Deleted: fd310e0
- SiStripApproximateClusterv2/src/classes.h:
  - Added: 39fe9bb
  - Deleted: 37babea
- RecoLocalTracker/SiStripClusterizer/plugins/SiStripClusters2ApproxClustersv1.cc:
  - Added: 39fe9bb
  - Modified: 1a03de5, 1064ace, 11d59de, 6ef4f3c, bbdf8a8
  - Deleted: 89ca71a
- RecoLocalTracker/SiStripClusterizer/python/SiStripClusters2ApproxClustersv1_cfi.py:
  - Added: 39fe9bb
  - Deleted: 6ef4f3c
- RecoLocalTracker/SiStripClusterizer/python/SiStripApproximatedClustersDump_cfi.py:
  - Added: 4616178
  - Modified: 879fc14
  - Deleted: 6ef4f3c
- RecoLocalTracker/SiStripClusterizer/interface/SiStripClusters2ApproxClustersv1.h:
  - Added: b47789c
  - Deleted: 42d38fc
- DataFormats/SiStripCluster/interface/SiStripApproximateClusterv1.h:
  - Added: 39fe9bb
  - Modified: 1064ace, 11d59de
  - Deleted: 89ca71a

cmsbuild · 2021-05-20T18:32:33Z

Pull request #33546 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

jpata · 2021-05-21T07:18:01Z

@cmsbuild please test

cmsbuild · 2021-05-21T10:33:57Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e1eef5/15228/summary.html
COMMIT: 214e8b4
CMSSW: CMSSW_12_0_X_2021-05-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33546/15228/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650463
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

jpata · 2021-05-24T14:13:24Z

+reconstruction

adds a new data format for HI
no changes to tests (none expected)
DPG presentation at https://indico.cern.ch/event/934815/contributions/4126184/attachments/2159648/3643496/TrackerDPG_20201209.pdf

cmsbuild · 2021-05-24T14:13:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-05-25T00:20:12Z

+1

Ivan added 5 commits April 27, 2021 16:57

Approximate clusters definition and producer

b47789c

Adding Approximated

39fe9bb

Adding ClusterDump and test .py

4616178

Including ClusterDump plugin

592f859

fising cluster dump config

879fc14

cmsbuild added this to the CMSSW_11_3_X milestone Apr 27, 2021

cmsbuild added new-package-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 27, 2021

mtosi reviewed Apr 27, 2021

View reviewed changes

DataFormats/SiStripCluster/interface/SiStripApproximateClusterv1.h Outdated Show resolved Hide resolved

mmusich reviewed Apr 27, 2021

View reviewed changes

SiStripApproximateClusterv2/BuildFile.xml Outdated Show resolved Hide resolved

SiStripApproximateClusterv2/src/classes.h Outdated Show resolved Hide resolved

removing misplaced files

37babea

cmsbuild removed the new-package-pending label Apr 27, 2021

mmusich reviewed Apr 27, 2021

View reviewed changes

Update RecoLocalTracker/SiStripClusterizer/plugins/SiStripClusters2Ap…

1a03de5

…proxClustersv1.cc Co-authored-by: Marco Musich <marco.musich@cern.ch>

VinInn reviewed Apr 27, 2021

View reviewed changes

DataFormats/SiStripCluster/interface/SiStripApproximateClusterv1.h Outdated Show resolved Hide resolved

Ivan added 2 commits April 27, 2021 19:47

intermediate fixing

42d38fc

fixing approx plugin and fixing interface

1064ace

pieterdavid reviewed Apr 27, 2021

View reviewed changes

Ivan added 2 commits April 28, 2021 10:08

fillDescription adding

11d59de

fixing fillDescriptors

6ef4f3c

VinInn reviewed Apr 28, 2021

View reviewed changes

DataFormats/SiStripCluster/interface/SiStripApproximateClusterv1.h Outdated Show resolved Hide resolved

VinInn reviewed Apr 28, 2021

View reviewed changes

DataFormats/SiStripCluster/interface/SiStripApproximateClusterv1.h Outdated Show resolved Hide resolved

VinInn reviewed Apr 28, 2021

View reviewed changes

DataFormats/SiStripCluster/interface/SiStripApproximateClusterv1.h Outdated Show resolved Hide resolved

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 20, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 20, 2021

code format

214e8b4

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 20, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 20, 2021

cmsbuild added tests-started and removed tests-pending labels May 21, 2021

cmsbuild added tests-approved and removed tests-started labels May 21, 2021

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels May 24, 2021

cmsbuild added orp-approved and removed orp-pending labels May 25, 2021

cmsbuild merged commit 92b8b51 into cms-sw:master May 25, 2021

mmusich mentioned this pull request Mar 29, 2022

review content saved in miniAOD in DeDxHitInfo to possibly reduce the size on file #36405

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SiStripApproximateCluster reduced data format for HI #33546

SiStripApproximateCluster reduced data format for HI #33546

icali commented Apr 27, 2021 •

edited

Loading

cmsbuild commented Apr 27, 2021

cmsbuild commented Apr 27, 2021

mmusich left a comment

cmsbuild commented Apr 27, 2021

pieterdavid left a comment

cmsbuild commented Apr 28, 2021

icali commented May 20, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

jpata commented May 21, 2021

cmsbuild commented May 21, 2021

jpata commented May 24, 2021

cmsbuild commented May 24, 2021

qliphy commented May 25, 2021

SiStripApproximateCluster reduced data format for HI #33546

SiStripApproximateCluster reduced data format for HI #33546

Conversation

icali commented Apr 27, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Apr 27, 2021

cmsbuild commented Apr 27, 2021

mmusich left a comment

Choose a reason for hiding this comment

cmsbuild commented Apr 27, 2021

pieterdavid left a comment

Choose a reason for hiding this comment

cmsbuild commented Apr 28, 2021

icali commented May 20, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

jpata commented May 21, 2021

cmsbuild commented May 21, 2021

Comparison Summary

jpata commented May 24, 2021

cmsbuild commented May 24, 2021

qliphy commented May 25, 2021

icali commented Apr 27, 2021 •

edited

Loading