-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1T phase-2: Update to histogram (Phase-1 like) jets #33606
Conversation
…phi of input candidates and synchronise bin edge effects with FW. (cherry picked from commit 1b2169a)
(cherry picked from commit 0f935a1)
(cherry picked from commit 0631865)
(cherry picked from commit 19fa96f)
(cherry picked from commit e7f4abe)
…ies. (cherry picked from commit c8de5ec)
(cherry picked from commit 7189024)
(cherry picked from commit 01e732f)
(cherry picked from commit 341ac43)
(cherry picked from commit dda20a7)
(cherry picked from commit 8217bc2)
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33606/22429
|
A new Pull Request was created by @cecilecaillol for master. It involves the following packages: DataFormats/L1Trigger @cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd2a58/14801/summary.html Comparison SummarySummary:
|
@EmyrClement @rekovic Can you please check this PR (rebasing of cms-l1t-offline#883) is ok from your side? |
+l1 |
@cecilecaillol This looks ok from my side, I get the same output before/after the rebase. |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hello there, after this was merged yesterday 11 unit tests started failing in our python3 IBs, in DEVEL and PY3 IB: I didn't investigated much just enough to see which is what this builds complain about. |
Thanks, @mrodozov for reporting. Do yu think that we will see the same issue if we do the PR-test in python3? How can we start to do PR-test with python-3 during the transition period? @smuzaffar @davidlange6 |
so one get the latest PY3 or DEVEL release before the change and tests against it |
please test |
abort |
test parameters:
|
please test |
-1 Failed Tests: UnitTests RelVals AddOn Unit TestsI found errors in the following unit tests: ---> test TestDQMOfflineConfiguration0 had ERRORS ---> test TestDQMOfflineConfiguration100 had ERRORS ---> test TestDQMOfflineConfiguration50 had ERRORS ---> test TestDQMOfflineConfiguration200 had ERRORS and more ... RelVals
Expand to see more relval errors ...AddOn Tests
Expand to see more addon errors ...
|
to answer how to do it if you are suspecting there might be a problem you can use the |
voila, the DQM tests failed :) |
PR description:
PR validation:
Rebase of cms-l1t-offline#883
if this PR is a backport please specify the original PR and why you need to backport that PR:
Rebase of cms-l1t-offline#883
Before submitting your pull requests, make sure you followed this checklist: