Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csctfeffciency fixed dphi for phi efficiency plot #3362

Merged
merged 1 commit into from
Apr 18, 2014

Conversation

unclok
Copy link

@unclok unclok commented Apr 16, 2014

dphi was incorrectly calculated which resulted in low efficiency at phi = 0 and 2pi
turned off drawing of fit in efficiency plots

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @unclok for CMSSW_6_2_X_SLHC.

csctfeffciency fixed dphi for phi efficiency plot

It involves the following packages:

L1Trigger/CSCTrackFinder

@cmsbuild, @Degano, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@andersonjacob
Copy link
Contributor

merge

passing tests
10000
10200
10400
11200
11400
12000
12800
13000
13600
14600

known failure
12200 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 16640 0 0
12400 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 34304 0 0
12600 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 34304 0 0
13800 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 34304 0 0
14000 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 34304 0 0
14200 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 16640 0 0
14400 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 16640 0 0

cmsbuild added a commit that referenced this pull request Apr 18, 2014
csctfeffciency fixed dphi for phi efficiency plot
@cmsbuild cmsbuild merged commit fe27d9f into cms-sw:CMSSW_6_2_X_SLHC Apr 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants