Fix leftover Timing parameters

[czangela]

PR description:

This PR removes a deprecated parameter from the module siPixelDigis (or SiPixelRawToDigi).

Based on this regexp it should include all remaining instances.

PR validation:

compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

[mmusich]

this is a duplicate of #33625

[mmusich]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33626/22487

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/Integration/python/clients/fed_dqm_sourceclient-live_cfg.py modified in PR(s): fix missing leftover Timing parameter in fed_dqm_sourceclient-live_cfg.py #33625

[cmsbuild]

A new Pull Request was created by @czangela for master.

It involves the following packages:

Calibration/LumiAlCaRecoProducers
DQM/Integration
DQM/SiPixelMonitorRawData
EventFilter/SiPixelRawToDigi

@perrotta, @malbouis, @andrius-k, @yuanchao, @kmaeshima, @tlampen, @ErnestaP, @ahmad3213, @jfernan2, @slava77, @jpata, @pohsun, @rvenditti, @francescobrivio can you please review it and eventually sign? Thanks.
@arossi83, @OzAmram, @batinkov, @hdelanno, @battibass, @makortel, @sroychow, @tocheng, @VinInn, @Martin-Grunewald, @dkotlins, @fioriNTU, @jandrea, @ferencek, @idebruyn, @mmusich, @threus, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild please abort

[mmusich]

@cmsbuild, please test

[perrotta]

Since you are cleaning, why not to remove also its definition also from

cmssw/EventFilter/SiPixelRawToDigi/plugins/SiPixelDigiToRaw.cc

Line 180 in 32c6228

desc.addUntracked<bool>("Timing", false)->setComment("deprecated");

?

[czangela]

Since you are cleaning, why not to remove also its definition also from

cmssw/EventFilter/SiPixelRawToDigi/plugins/SiPixelDigiToRaw.cc

Line 180 in 32c6228

desc.addUntracked<bool>("Timing", false)->setComment("deprecated");

?

The parameter in question was actually in EventFilter/SiPixelRawToDigi/plugins/SiPixelRawToDigi.cc. This other Timing parameter should be unrelated, but it can be removed as well.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c6c43/14864/summary.html
COMMIT: 32c6228
CMSSW: CMSSW_12_0_X_2021-05-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33626/14864/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2662646
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2662617
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• Technical
• Jenkinst tests pass

[jfernan2]

+1

[qliphy]

kindly ping @cms-sw/alca-l2

[yuanchao]

+1

• modification on python configuration only (compile ok)
• WF matrix tests and unit tests all passed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

@czangela Would you please update the PR description? This PR is not a backport of #33526, right?

[mmusich]

This PR is not a backport of #33526, right?

@qliphy it's not. It's a follow-up on that PR that removed one configuration parameter from the Pixel raw2digi.
What do you suggest as a title?

[qliphy]

@mmusich
It reads:
“if this PR is a backport please specify the original PR and why you need to backport that PR:
#33526”
However, this PR is not a backport of #33526
So probably just simply remove it, and mention #33526 in other place.

[mmusich]

Why is this preventing from merge?

[mmusich]

type bug-fix

[qliphy]

+1