Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated physics configurations for Geant4 #33633

Merged
merged 3 commits into from May 8, 2021

Conversation

civanch
Copy link
Contributor

@civanch civanch commented May 5, 2021

PR description:

After migration to Geant4 10.7 Physics Lists require modifications. In this PR Physics Lists based on FTF string model are updated:

  1. Neutron time cut is removed from Physics List in order to avoid duplication of such cut also implemented in CMS Stepping and Stacking actions. This removes inconsistency not allowing tracking of neutrons to ZDC, in Stepping action a different time cut is applied to the forward neutrons.
  2. SteppingAction and StackingAction classes very reviewed and a coherent modification for time window check is added. Also minor clean-up of these classes is done. A minor bug is fixed, which means definite kill of particle which is out of time.
  3. CMS hadron inelastic physics constructor allows specific configuration for pions, kaons, protons, and neutrons
  4. FTFP_BERT_EMM is CMS default using Geant4 10.7 overlap between the Bertini Cascade and the FTF string model, except more wide overlap for pions
  5. FTFP_BERT_EMM_TRK use optimized overlap for kaons on top of FTFP_BERT_EMM

It is expected, that regression will be broken due to forward neutrons especially in QCD FWs.

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport that PR:

no

@civanch
Copy link
Contributor Author

civanch commented May 5, 2021

@bsunanda , FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33633/22497

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2021

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented May 5, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edb4ea/14879/summary.html
COMMIT: 4f20eb7
CMSSW: CMSSW_12_0_X_2021-05-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33633/14879/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 46479 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662646
  • DQMHistoTests: Total failures: 281691
  • DQMHistoTests: Total nulls: 186
  • DQMHistoTests: Total successes: 2380747
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.178 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.063 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.064 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.181 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: found differences in 11 / 36 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33633/22519

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

Pull request #33633 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@civanch
Copy link
Contributor Author

civanch commented May 6, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edb4ea/14905/summary.html
COMMIT: 80799ec
CMSSW: CMSSW_12_0_X_2021-05-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33633/14905/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 50092 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662646
  • DQMHistoTests: Total failures: 297946
  • DQMHistoTests: Total nulls: 181
  • DQMHistoTests: Total successes: 2364497
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -52.481 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.063 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 250202.181 ): 0.293 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 7.3 ): -0.495 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -6.517 KiB SiStrip/MechanicalView
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: found differences in 12 / 36 workflows

@civanch
Copy link
Contributor Author

civanch commented May 6, 2021

+1

This PR includes change of logic of cut on track time. This affects simulation histories, so regression is lost.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9c955a4 into cms-sw:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants