Addition to PixelDQM of Template correction to cluster charge

[arossi83]

PR description:

With this PR we introduce new distribution to the PixelPhase1 DQM:

• Cluster Charge corrected with the tempalte
• the template correction itself
  (this distribution are added for each layers/rings/disks)

PR validation:

runTheMatrix.py -l 11024

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no backport foreseen

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33635/22501

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33635/22501/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33635/22501/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[arossi83]

A CPU consumption analysis has been done. This changes will increase the time needed by the module form ~40ms to ~70ms. A higher impact (~180ms) is expected on the first event due to the loading of the huge template matrix.

[arossi83]

@mmusich @tvami @sroychow FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33635/22503

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @arossi83 (Alessandro Rossi) for master.

It involves the following packages:

DQM/SiPixelPhase1Track
DQMOffline/Trigger

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @trocino, @HuguesBrun, @hdelanno, @missirol, @sroychow, @jhgoh, @calderona, @sscruz, @Fedespring, @threus, @jandrea, @idebruyn, @rociovilar, @mtosi, @cericeci, @fioriNTU this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33635/22505

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33635/22505/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33635/22505/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33635/22549

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #33635 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f49f31/14939/summary.html
COMMIT: ca9669f
CMSSW: CMSSW_12_0_X_2021-05-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33635/14939/install.sh to create a dev area with all the needed externals and cmssw changes.

Found compilation warnings

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2662646
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2662617
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 288.344 KiB( 36 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 24.029 KiB PixelPhase1/Tracks
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[qliphy]

@arossi83 There is a IB build warning from this PR
which indicates "InvalidIncludes" of "CondFormats/SiPixelTransient/src/SiPixelTemplate.cc" :
https://cmssdt.cern.ch/SDT/jenkins-artifacts/invalid-includes/CMSSW_12_0_X_2021-05-09-0000/slc7_amd64_gcc900/DQM/SiPixelPhase1Track/

From the summary page of PR test, there is also a warning which I overlooked:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f49f31/14939/build-logs/DQM/SiPixelPhase1Track/log.html

Would you please have a check and fix? Thanks!

[makortel]

How about just

const TrackerGeometry& tracker = iSetup.get(trackerGeomToken_);

? Or actually, tracker seems to be unused so how about removing these two lines?

[mmusich]

@qliphy @makortel @arossi83 see #33669