Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD validation: update standalone test configuration to scenario D76, use up-to-date fragments #33649

Merged
merged 1 commit into from
May 7, 2021

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented May 6, 2021

PR description:

Update of the standalone test configuration in Validation/MtdValidation/test to use geometry scenario D76, the more modern definition of geometry fragments, and newly introduced flags for expert checks.

PR validation:

The cfg correctly runs on the output of wf 34634.0 and provides the desired output.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33649/22528

  • This PR adds an extra 12KB to repository

@fabiocos
Copy link
Contributor Author

fabiocos commented May 6, 2021

@gsorrentino18 @casarsa FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Validation/MtdValidation

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented May 6, 2021

please test

merely formal, the updated cfg is not probed by PR test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-719eec/14917/summary.html
COMMIT: e03f8ca
CMSSW: CMSSW_12_0_X_2021-05-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33649/14917/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662646
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2662623
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented May 6, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 7, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants