Turn-off GEM-CSC integrated local trigger in valCscStage2Digis [12_0_X]

[dildick]

PR description:

Turn-off GEM-CSC integrated local trigger in valCscStage2Digis. GEM-CSC trigger not yet deployed at P5. Previously it was turned off in 11_2_X.

PR validation:

Tested with WF 11634.0.

 11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Mon May 10 10:28:02 2021-date Mon May 10 10:07:01 2021; exit: 0 0 0 0 0
1 1 1 1 1 tests passed, 0 0 0 0 0 failed

if this PR is a backport please specify the original PR and why you need to backport that PR:

Needs to be backported to 11_3_X

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33678/22580

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DQM/L1TMonitor

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

urgent
to fix 11_3_0 for the next MWGR (if I understand correctly)

[dildick]

Hi @silviodonato

This PR (and the 11_3 backport) are definitely necessary. They switch off the GEM-CSC trigger at P5. The firmware for the GEM-CSC trigger has not yet been deployed. So those PRs can be merged.

However, I have reason to believe that some kind of data corruption is happening in very rare cases. I'm investigating this now. More details to follow soon.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1583ed/14971/summary.html
COMMIT: f4bb6a8
CMSSW: CMSSW_12_0_X_2021-05-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33678/14971/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2663174
• DQMHistoTests: Total failures: 37
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2663115
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[dildick]

There are 37 failures, one from pixel, 36 from L1TEMU/L1TdeCSCTPG in Run-3, all in ME1/b because the GE1/1-ME1/1 integrated local trigger has been switched off for Run-3 data for now.

[jfernan2]

I do not see the change in wf 8.0

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_X_2021-05-10-1100+1583ed/42704/dqm-histo-comparison-summary.html

[dildick]

That appears to be a known issue. It has showed up in all my PRs.

[jfernan2]

OK, but it seems to be a false positive
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_X_2021-05-10-1100+1583ed/42704/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/Pixel__avgfedDigiOccvsLumi.png

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1