Improve quality control for CSC trigger primitives

[dildick]

PR description:

I did some additional work during the investigation of PR #33679 to improve the quality control of the CSC trigger primitives. (tighter checks on the ALCT/CLCT/LCT quality, CLCT CFEB, CLCT/LCT pattern number).

PR validation:

Tested with WF 11634.0. There should be no changes in any WF.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33686/22592

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @civanch, @cecilecaillol, @mdhildreth can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald, @ptcox, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52cfc7/14987/summary.html
COMMIT: cf7e6b1
CMSSW: CMSSW_12_0_X_2021-05-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33686/14987/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2663174
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2663133
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1