-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve quality control for CSC trigger primitives #33686
Improve quality control for CSC trigger primitives #33686
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33686/22592
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: DataFormats/CSCDigi @cmsbuild, @rekovic, @civanch, @cecilecaillol, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52cfc7/14987/summary.html Comparison SummarySummary:
|
+l1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
I did some additional work during the investigation of PR #33679 to improve the quality control of the CSC trigger primitives. (tighter checks on the ALCT/CLCT/LCT quality, CLCT CFEB, CLCT/LCT pattern number).
PR validation:
Tested with WF 11634.0. There should be no changes in any WF.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
Before submitting your pull requests, make sure you followed this checklist: