NanoAOD:migrate modules to ESConsumes

[sroychow]

PR description:

Migrate two modules - L1TriggerResultsConverter and LHCInfoProducer, to access data from EventSetup with ESConsumes.
No changes are expected due to this.

PR validation:

Code compiles and wf 136.8523 runs.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not needed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33721/22649

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/plugins/L1TriggerResultsConverter.cc modified in PR(s): Remove hardcoded number (255) about the L1 prefiring #33711

[cmsbuild]

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[gouskos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b3ccd/15062/summary.html
COMMIT: 501de41
CMSSW: CMSSW_12_0_X_2021-05-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33721/15062/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1264 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 3674
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2644526
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.699 KiB( 36 files compared)
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

I confirm that the 4 call of bug type "EventSetupRecord::get function called" is gone
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b3ccd/15062/llvm-analysis/

see previous report
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b82149/14850/llvm-analysis/

[mariadalfonso]

• No significant changes to the logs found
• Reco comparison results: 1264 differences found in the comparisons

These differences are associated to the RunHI2011wf140p53 and are unrelated to this PR.

[mariadalfonso]

+xpog

technical PR, no changes in performances

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1