Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source_only flag for source-only dependencies in alignment #33729

Merged
merged 1 commit into from
May 19, 2021
Merged

Add source_only flag for source-only dependencies in alignment #33729

merged 1 commit into from
May 19, 2021

Conversation

guitargeek
Copy link
Contributor

PR description:

Add source_only flag for source-only dependencies in alignment. These dependencies were automatically found with this script.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33729/22664

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

Alignment/APEEstimation
Alignment/CommonAlignment
Alignment/CommonAlignmentAlgorithm
Alignment/CommonAlignmentMonitor
Alignment/CommonAlignmentProducer
Alignment/LaserAlignmentSimulation
Alignment/MillePedeAlignmentAlgorithm
Alignment/MuonAlignmentAlgorithms
Alignment/OfflineValidation
Alignment/ReferenceTrajectories
Alignment/TrackerAlignment

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @abbiendi, @jhgoh, @tocheng, @tlampen, @mmusich, @trocino this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@guitargeek guitargeek closed this May 13, 2021
@guitargeek guitargeek reopened this May 13, 2021
@tlampen
Copy link
Contributor

tlampen commented May 14, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d268e/15094/summary.html
COMMIT: 1ed96ac
CMSSW: CMSSW_12_0_X_2021-05-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33729/15094/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2648242
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2648207
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@yuanchao
Copy link
Contributor

+1

  • Add source_only flag for alignment. (only buildfile modified)
  • WF matrix tests and unit tests all passed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 19, 2021

+1

@cmsbuild cmsbuild merged commit b2f7812 into cms-sw:master May 19, 2021
@guitargeek guitargeek deleted the source_only_2 branch May 19, 2021 09:19
@guitargeek guitargeek restored the source_only_2 branch May 19, 2021 09:19
@guitargeek guitargeek deleted the source_only_2 branch May 19, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants