-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependencies in FWCore BuildFiles #33755
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33755/22707
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Concurrency @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: /cvmfs/cms-ib.cern.ch/nweek-02681/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/ESSources/plugins/CondCoreESSourcesPlugins/CondDBESSource.cc.o: in function `cond::persistency::convertoToOracleConnection(std::__cxx11::basic_string, std::allocator > const&)': CondDBESSource.cc:(.text._ZN4cond11persistency26convertoToOracleConnectionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE[_ZN4cond11persistency26convertoToOracleConnectionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE]+0x8f0): undefined reference to `boost::basic_regex > >::do_assign(char const*, char const*, unsigned int)' /cvmfs/cms-ib.cern.ch/nweek-02681/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: CondDBESSource.cc:(.text._ZN4cond11persistency26convertoToOracleConnectionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE[_ZN4cond11persistency26convertoToOracleConnectionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE]+0x940): undefined reference to `boost::basic_regex > >::do_assign(char const*, char const*, unsigned int)' /cvmfs/cms-ib.cern.ch/nweek-02681/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: CondDBESSource.cc:(.text._ZN4cond11persistency26convertoToOracleConnectionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE[_ZN4cond11persistency26convertoToOracleConnectionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE]+0x996): undefined reference to `boost::basic_regex > >::do_assign(char const*, char const*, unsigned int)' /cvmfs/cms-ib.cern.ch/nweek-02681/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: CondDBESSource.cc:(.text._ZN4cond11persistency26convertoToOracleConnectionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE[_ZN4cond11persistency26convertoToOracleConnectionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE]+0xac2): undefined reference to `boost::re_detail_107500::perl_matcher<__gnu_cxx::__normal_iterator, std::allocator > >, std::allocator, std::allocator > > > >, boost::regex_traits > >::construct_init(boost::basic_regex > > const&, boost::regex_constants::_match_flags)' collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc900/src/CondCore/ESSources/plugins/CondCoreESSourcesPlugins/libCondCoreESSourcesPlugins.so] Error 1 Leaving library rule at src/CondCore/ESSources/plugins >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-17-1100/src/CondCore/ESSources/test/TestCondCoreESSources.cpp >> Building binary UnitTestConcurrentIOVsCondCore Copying tmp/slc7_amd64_gcc900/src/CondCore/ESSources/test/UnitTestConcurrentIOVsCondCore/UnitTestConcurrentIOVsCondCore to productstore area: |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33755/22708
|
Pull request #33755 was updated. @smuzaffar, @Dr15Jones, @malbouis, @makortel, @cmsbuild, @yuanchao, @tlampen, @ggovi, @pohsun, @francescobrivio can you please check and sign again. |
please test |
+hlt |
+core |
+1
|
+1 |
+1 |
+1 |
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The extra dependencies were shown by the libCheck done by the IBs.
PR validation:
Code compiles.
completes cms-sw/framework-team#145