Migrate ED modules to use esConsumes

[calderona]

PR description:

Migrate ED modules to use esConsumes, for the DQMOffline/Muon package.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33786/22758

• This PR adds an extra 56KB to repository

[cmsbuild]

A new Pull Request was created by @calderona for master.

It involves the following packages:

DQMOffline/Muon

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@sscruz, @barvic, @abbiendi, @Fedespring, @bellan, @HuguesBrun, @jhgoh, @ptcox, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-447e94/15193/summary.html
COMMIT: 5bc6101
CMSSW: CMSSW_12_0_X_2021-05-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33786/15193/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 4.22

----- Begin Fatal Exception 19-May-2021 23:17:38 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  Event run: 160960 lumi: 277 event: 10001650 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module MuonEnergyDepositAnalyzer/'muonEnergyDepositAnalyzer'
Exception Message:
No data of type "TransientTrackBuilder" with label "" in record "TransientTrackRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

• 140.53

----- Begin Fatal Exception 19-May-2021 23:18:37 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  Event run: 182124 lumi: 140 event: 6405339 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module MuonEnergyDepositAnalyzer/'muonEnergyDepositAnalyzer'
Exception Message:
No data of type "TransientTrackBuilder" with label "" in record "TransientTrackRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

• 8.0

----- Begin Fatal Exception 19-May-2021 23:19:46 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 6 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module MuonEnergyDepositAnalyzer/'muonEnergyDepositAnalyzer'
Exception Message:
No data of type "TransientTrackBuilder" with label "" in record "TransientTrackRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 4.53
• 7.3
• 136.731
• 140.56
• 136.793
• 136.874
• 1001.0
• 1000.0
• 9.0
• 1306.0
• 25.0
• 312.0
• 1330.0
• 10042.0
• 10024.0
• 10824.0
• 11634.0
• 12434.0
• 25202.0
• 10224.0
• 23234.0
• 34634.0
• 28234.0
• 250202.181
• 34834.999

RelVals-INPUT

• 134.813134.813_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2/step2_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2.log
• 136.733136.733_RunCosmics2016B+RunCosmics2016B+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2/step2_RunCosmics2016B+RunCosmics2016B+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2.log
• 138.1138.1_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3/step2_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3.log

Expand to see more relval errors ...

• 138.2
• 140.56
• 1001.2
• 1040.0

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33786/22770

• This PR adds an extra 56KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33786/22770/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33786/22770/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33786/22821

• This PR adds an extra 60KB to repository

[cmsbuild]

Pull request #33786 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33786/22822

• This PR adds an extra 60KB to repository

[cmsbuild]

Pull request #33786 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-447e94/15269/summary.html
COMMIT: a86456a
CMSSW: CMSSW_12_0_X_2021-05-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33786/15269/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2650451
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1