-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing <cstddef> includes for size_t #33820
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33820/22819
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: DataFormats/HcalDigi @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9340a3/15265/summary.html Comparison SummarySummary:
|
@@ -1,6 +1,7 @@ | |||
#ifndef DataFormats_SiPixelDigi_interface_SiPixelDigisSoA_h | |||
#define DataFormats_SiPixelDigi_interface_SiPixelDigisSoA_h | |||
|
|||
#include <cstddef> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pretend that the correct action is to change size_t in uint32_t
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@VinInn , this is not the only place where size_t is used. I do not know arguments pro and contr but if size_t should be substituted by uint32_t, then this should be a campaign to substitute everywhere. |
+1 |
PR description:
To make cmssw compile with gcc 11.
PR validation:
Building CMSSW with gcc 11 gives errors without this PR, but succeeds with this PR.