Fix clang warnings #33912

mrodozov · 2021-05-31T14:01:48Z

PR description:

There are six warnings reported by the CLANG builds which seems to be legit
https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc7_amd64_gcc900/www/sun/12.0.CLANG-sun-23/CMSSW_12_0_CLANG_X_2021-05-30-2300
Not sure if the change for RecMuon->eta() was originaly meant to be over fabs(RecMuon->eta()) only

PR validation:

Builds with the CLANG IB without the warnings

cmsbuild · 2021-05-31T14:08:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33912/22980

This PR adds an extra 20KB to repository

cmsbuild · 2021-05-31T14:08:24Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers
RecoLocalTracker/Phase2TrackerRecHits
RecoLocalTracker/SiPhase2Clusterizer

@perrotta, @malbouis, @yuanchao, @tlampen, @kpedro88, @cmsbuild, @srimanob, @slava77, @jpata, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mtosi, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @rovere, @gpetruc, @mmusich, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mrodozov · 2021-05-31T14:13:42Z

ping

mrodozov · 2021-05-31T14:13:55Z

please test

Calibration/HcalAlCaRecoProducers/plugins/AlCaLowPUHBHEMuonFilter.cc

…ter.cc probably what should've been Co-authored-by: Slava Krutelyov <slava77@gmail.com>

cmsbuild · 2021-05-31T15:43:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33912/22987

This PR adds an extra 20KB to repository

cmsbuild · 2021-05-31T15:44:15Z

Pull request #33912 was updated. @perrotta, @malbouis, @yuanchao, @tlampen, @kpedro88, @cmsbuild, @srimanob, @slava77, @jpata, @pohsun, @francescobrivio can you please check and sign again.

mrodozov · 2021-05-31T15:44:48Z

please test

mrodozov · 2021-05-31T21:40:19Z

please test

cmsbuild · 2021-06-01T01:17:55Z

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5746ee/15492/summary.html
COMMIT: cae8ad2
CMSSW: CMSSW_12_0_X_2021-05-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33912/15492/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

fastsim1cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Mon May 31 23:58:56 2021-date Mon May 31 23:54:26 2021 s - exit: 35584

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650463
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

mrodozov · 2021-06-01T11:30:37Z

hm that fails exactly in recotracker :/

mrodozov · 2021-06-01T11:31:02Z

please test
I think this will be consistent, lets see

cmsbuild · 2021-06-01T18:07:59Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5746ee/15506/summary.html
COMMIT: cae8ad2
CMSSW: CMSSW_12_0_X_2021-05-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33912/15506/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650463
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

slava77 · 2021-06-02T02:56:00Z

+reconstruction

for #33912 cae8ad2

changes in reco are technical (removing a fabs on uint values)

yuanchao · 2021-06-03T12:02:40Z

+1

one of the check still in pending
fix six warnings by CLANG builds (fabs -> std::abs, technical)

mrodozov · 2021-06-03T12:57:36Z

please test for CMSSW_12_0_CLANG_X/slc7_amd64_gcc900

mrodozov · 2021-06-03T12:58:05Z

lets get this comparison finished for CLANG

cmsbuild · 2021-06-03T21:47:26Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5746ee/15609/summary.html
COMMIT: cae8ad2
CMSSW: CMSSW_12_0_CLANG_X_2021-06-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33912/15609/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

You potentially added 5038 lines to the logs
Reco comparison results: 19764 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 66309
DQMHistoTests: Total nulls: 25
DQMHistoTests: Total successes: 2584130
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -45.687 KiB( 36 files compared)
DQMHistoSizes: changed ( 136.793 ): 0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.874 ): 0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: found differences in 1 / 36 workflows

srimanob · 2021-06-04T15:49:35Z

+Upgrade

cmsbuild · 2021-06-04T15:49:57Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-05T01:25:43Z

+1

Fix clang warnings

8f97786

cmsbuild added this to the CMSSW_12_0_X milestone May 31, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels May 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 31, 2021

cmsbuild added tests-started and removed tests-pending labels May 31, 2021

slava77 reviewed May 31, 2021

View reviewed changes

Calibration/HcalAlCaRecoProducers/plugins/AlCaLowPUHBHEMuonFilter.cc Outdated Show resolved Hide resolved

Update Calibration/HcalAlCaRecoProducers/plugins/AlCaLowPUHBHEMuonFil…

cae8ad2

…ter.cc probably what should've been Co-authored-by: Slava Krutelyov <slava77@gmail.com>

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels May 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 31, 2021

cmsbuild added tests-started and removed tests-pending labels May 31, 2021

cmsbuild added tests-rejected and removed tests-started labels Jun 1, 2021

cmsbuild added tests-started and removed tests-rejected labels Jun 1, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 1, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 2, 2021

cmsbuild added alca-approved and removed alca-pending labels Jun 3, 2021

cmsbuild removed pending-signatures upgrade-pending labels Jun 4, 2021

cmsbuild added fully-signed upgrade-approved labels Jun 4, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 5, 2021

cmsbuild merged commit c45844c into cms-sw:master Jun 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix clang warnings #33912

Fix clang warnings #33912

mrodozov commented May 31, 2021 •

edited

Loading

cmsbuild commented May 31, 2021

cmsbuild commented May 31, 2021

mrodozov commented May 31, 2021

mrodozov commented May 31, 2021

cmsbuild commented May 31, 2021

cmsbuild commented May 31, 2021

mrodozov commented May 31, 2021

mrodozov commented May 31, 2021

cmsbuild commented Jun 1, 2021

mrodozov commented Jun 1, 2021

mrodozov commented Jun 1, 2021

cmsbuild commented Jun 1, 2021

slava77 commented Jun 2, 2021

yuanchao commented Jun 3, 2021

mrodozov commented Jun 3, 2021

mrodozov commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

srimanob commented Jun 4, 2021

cmsbuild commented Jun 4, 2021

qliphy commented Jun 5, 2021

Fix clang warnings #33912

Fix clang warnings #33912

Conversation

mrodozov commented May 31, 2021 • edited Loading

PR description:

PR validation:

cmsbuild commented May 31, 2021

cmsbuild commented May 31, 2021

mrodozov commented May 31, 2021

mrodozov commented May 31, 2021

cmsbuild commented May 31, 2021

cmsbuild commented May 31, 2021

mrodozov commented May 31, 2021

mrodozov commented May 31, 2021

cmsbuild commented Jun 1, 2021

AddOn Tests

Comparison Summary

mrodozov commented Jun 1, 2021

mrodozov commented Jun 1, 2021

cmsbuild commented Jun 1, 2021

Comparison Summary

slava77 commented Jun 2, 2021

yuanchao commented Jun 3, 2021

mrodozov commented Jun 3, 2021

mrodozov commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

Comparison Summary

srimanob commented Jun 4, 2021

cmsbuild commented Jun 4, 2021

qliphy commented Jun 5, 2021

mrodozov commented May 31, 2021 •

edited

Loading