Run3-sim85 Change HF ShowerLibrary Producer by Lev

[bsunanda]

PR description:

Change HF ShowerLibrary Producer by Lev

PR validation:

Use runTheMatrix test workflow 11634

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33971/23067

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33971/23067/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33971/23067/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33971/23068

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

SimG4CMS/Calo
SimG4CMS/ShowerLibraryProducer

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7e3b3/15634/summary.html
COMMIT: f6fe0fd
CMSSW: CMSSW_12_0_X_2021-06-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33971/15634/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9011 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 39452
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2611012
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[abdoulline]

A tiny difference appeared in HF in many workflows, which may not be a problem per se.

[civanch]

@bsunanda , I am confused: a) these classes are not used in mainstream simulation, so regression should 100%; b) there are somewhere hidden symbols - in truth number of differences is much less.

[bsunanda]

One changed file comes for standard production. I shall try to see that default settings reproduce old results for this.

[bsunanda]

I believe the files concerned are unchanged files for a long time before application of any code check. That might have left lots of white spaces. I have no other explanation.

[civanch]

@bsunanda , in past I faced the same problem when take a file from e-mail - it is identical but diff shows differences in each line.

[makortel]

Could it be different line endings, DOS (\r\n) vs Unix (\n)?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33971/23121

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #33971 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7e3b3/15726/summary.html
COMMIT: a67231d
CMSSW: CMSSW_12_0_X_2021-06-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33971/15726/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648335
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2648312
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[abdoulline]

Thank you, Sunanda! 👍🏻

[civanch]

Could it be different line endings, DOS (\r\n) vs Unix (\n)?

I think so.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1