-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-sim85 Change HF ShowerLibrary Producer by Lev #33971
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33971/23067
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33971/23068
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: SimG4CMS/Calo @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7e3b3/15634/summary.html Comparison SummarySummary:
|
A tiny difference appeared in HF in many workflows, which may not be a problem per se. |
@bsunanda , I am confused: a) these classes are not used in mainstream simulation, so regression should 100%; b) there are somewhere hidden symbols - in truth number of differences is much less. |
One changed file comes for standard production. I shall try to see that default settings reproduce old results for this. |
I believe the files concerned are unchanged files for a long time before application of any code check. That might have left lots of white spaces. I have no other explanation. |
@bsunanda , in past I faced the same problem when take a file from e-mail - it is identical but diff shows differences in each line. |
Could it be different line endings, DOS ( |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33971/23121
|
Pull request #33971 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7e3b3/15726/summary.html Comparison SummarySummary:
|
Thank you, Sunanda! 👍🏻 |
I think so. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Change HF ShowerLibrary Producer by Lev
PR validation:
Use runTheMatrix test workflow 11634
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special