-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DQM/TrackerRemapper] add unit tests #34159
Conversation
…d bookForwardHistograms respectively, and propagate it to dependencies
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34159/23361
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/OfflineValidation @malbouis, @andrius-k, @yuanchao, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @tlampen, @ggovi, @pohsun, @rvenditti, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-263610/16006/summary.html Comparison SummarySummary:
|
+1 |
+1
|
ping @cms-sw/db-l2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The main goal of this PR is to provide catch2 unit test for the classes in the package
DQM/TrackerRemapper
Additionally some technical commits are added:
Phase1PixelMaps
to check if histograms are booked (ce77cf9 )bookBarrelBins
andbookForwardBins
withbookBarrelHistograms
andbookForwardHistograms
respectively, and propagate it to dependencies (ae32d30)Phase1PixelMaps
about the histograms being booked (2b8b5bb )PR validation:
Run the augmented unit tests.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and no backport is needed.