Add customisation without EE

[mark-grimes]

Stops the ECal trigger primitive producer from using the endcaps in scenarios without EE (Shashlik and HGCal). This was discussed with @kpedro88 and @ianna in the comments for #3229, I've only just gotten around to adding it. Previously the Shashlik (EDIT - I meant HGCal) scenarios failed in step 2 with:

----- Begin Fatal Exception 22-Apr-2014 11:20:00 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1
   [1] Running path 'digitisation_step'
   [2] Calling beginRun for module EcalTrigPrimProducer/'simEcalTriggerPrimitiveDigis'
Exception Message:
No "EcalEndcapGeometryRecord" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

This fixes that error, although step 2 still fails with:

cmsRun: <build path>/src/SimCalorimetry/EcalSimAlgos/src/ESDigitizer.cc:70: void ESDigitizer::setGain(int): Assertion `0 != m_detIds && 0 != m_detIds->size()' failed.

[mark-grimes]

Tests 10000, 10200, 10400, 11200, 11400, 12000, 12800, 13000, 13600 and 14600 pass all steps.
Tests 12400, 12600, 13800 and 14000 fail in step 2 with known errors.
Tests 12200, 14200 and 14400 now still fail in step 2, but with the error mentioned above instead of the old one. I'll wait for an okay from geometry before merging.

[cmsbuild]

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Add customisation without EE

It involves the following packages:

Configuration/PyReleaseValidation
SLHCUpgradeSimulations/Configuration

@civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mark-grimes]

I had assumed this would require a signature from Geometry, but that isn't the case. @ianna does this match how you thought the customisation should be?

[ianna]

@mark-grimes - MixingMdule needs customisation. There is already a new plugin EcalPhaseIIDigiProducer available to customise an accumulatorType in a ecalDigitizer configuration which is used by a MixingModule.

[mark-grimes]

@ianna is this what you meant? With this line added test 14200 (Extended2023HGCal) passes digitisation then crashes in step 3 with

#5  0x00002b6580e83068 in ECAL2DPositionCalcWithDepthCorr::update(edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-04-20-1400/lib/slc5_amd64_gcc472/libRecoParticleFlowPFClusterProducer.so
#6  0x00002b6580e330c3 in PFClusterProducer::beginLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-04-20-1400/lib/slc5_amd64_gcc472/pluginRecoParticleFlowPFClusterProducerPlugins.so
#7  0x00002b655a2910a0 in edm::EDProducer::doBeginLuminosityBlock(edm::LuminosityBlockPrincipal&, edm::EventSetup const&, edm::CurrentProcessingContext const*) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-04-20-1400/lib/slc5_amd64_gcc472/libFWCoreFramework.so

Test 12400 (Extended2023SHCal) still fails in step 2 with:

cmsRun: <build path>/src/Geometry/EcalAlgo/src/EcalPreshowerGeometry.cc:136: virtual void EcalPreshowerGeometry::initializeParms(): Assertion `0 != n1minus && 0 != n2minus && 0 != n1plus && 0 != n2plus' failed.

[mark-grimes]

merge

[cmsbuild]

Pull request #3420 was updated. @civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please check and sign again.