-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes needed for UBSAN IBs: null destination pointer #34264
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34264/23552
|
please test |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: CalibCalorimetry/EcalCorrelatedNoiseAnalysisAlgos @yuanchao, @malbouis, @pohsun, @tlampen, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04d8f2/16262/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
+alca -tests and comparisons fine, (except for workflow 140.53, in which different files were used) |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
UBSAN IBs failed to build with error
I think allocated memory is used without first checking if it is properly allocated or not e.g. adding a condition to check if
f_in != nullptr
also fixes the UBSAN build error. But I think there is no need to allocate/deallocate memory in tis case.