HCAL: move data-specific SeverityLevel customization(s) to Reconstruction_Data_cff.py

[abdoulline]

PR description:

Suggested by @slava77 in (issue) #27767
re-arrangement of HCAL data-specific SeverityLevel settings (of RecHits flags) :
move the relevant stuff from RecoTLR_cff.py customization snippets
to Reconstruction_Data_cff.py appropriate era/modifiers.
NB: data settings are now in sync with the MC ones for >=Run3
(First they were synchronized yet in RecoTLR_cff.py in #33520 by @hatakeyamak )

PR validation:

runTheMatrix.py -l limited --ibeos --useInput all

Checked explicitly that SeverityLevel groups stayed unchanged w/wo this PR in
(1) 136.731_RunSinglePh2016B
(2) 136.793_RunDoubleEG2017C
(3) 136.874_RunEGamma2018C

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34282/23590

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

Configuration/DataProcessing
Configuration/StandardSequences

@cmsbuild, @silviodonato, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @ebrondol, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[qliphy]

cc @cms-sw/hcal-dpg-l2

[qliphy]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9daf7/16332/summary.html
COMMIT: 0f13527
CMSSW: CMSSW_12_0_X_2021-06-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34282/16332/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785682
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[qliphy]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@slava77,@perrotta,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

[slava77]

+reconstruction

for #34282 0f13527

• python configuration changes are in line with the PR description and the preceding discussion in review data-specific modifications for RECO related to HCAL noise flagging #27767
• jenkins tests pass and comparisons with the baseline show no differences, as expected

[qliphy]

+operations

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1