-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport to 9_4_X] Allow to suppress ExternalLHEProducer exception if not all events were processed #34359
[Backport to 9_4_X] Allow to suppress ExternalLHEProducer exception if not all events were processed #34359
Conversation
A new Pull Request was created by @justinasr (Justinas Rumševičius) for CMSSW_9_4_X. It involves the following packages: GeneratorInterface/LHEInterface @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1a59c/16528/summary.html Comparison SummarySummary:
|
@qliphy @silviodonato there are 105 failures. The new if will not be entered in the above tests so everything should be identical as the tests of 10_6 showed. So I am happy to sign. But let me know if I am missing something. |
Thanks @qliphy . Same is also true for 8_0: |
+generators |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR enables to suppress an exception thrown by ExternalLHEProducer using a VALIDATION_RUN environment variable.
PR validation:
scram b runtests
testsIf this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #33624 including suggestion added with #33674.
Backport is needed in all releases that are still used in Monte Carlo production.