Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 9_4_X] Allow to suppress ExternalLHEProducer exception if not all events were processed #34359

Merged
merged 1 commit into from
Jul 8, 2021
Merged

[Backport to 9_4_X] Allow to suppress ExternalLHEProducer exception if not all events were processed #34359

merged 1 commit into from
Jul 8, 2021

Conversation

justinasr
Copy link
Contributor

PR description:

This PR enables to suppress an exception thrown by ExternalLHEProducer using a VALIDATION_RUN environment variable.

PR validation:

  • scram b runtests tests

If this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #33624 including suggestion added with #33674.
Backport is needed in all releases that are still used in Monte Carlo production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

A new Pull Request was created by @justinasr (Justinas Rumševičius) for CMSSW_9_4_X.

It involves the following packages:

GeneratorInterface/LHEInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@agrohsje
Copy link

agrohsje commented Jul 7, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1a59c/16528/summary.html
COMMIT: 5bc451e
CMSSW: CMSSW_9_4_X_2021-07-04-0000/slc6_amd64_gcc630
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34359/16528/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 105
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721226
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • TriggerResults: no differences found

@agrohsje
Copy link

agrohsje commented Jul 8, 2021

@qliphy @silviodonato there are 105 failures. The new if will not be entered in the above tests so everything should be identical as the tests of 10_6 showed. So I am happy to sign. But let me know if I am missing something.

@qliphy
Copy link
Contributor

qliphy commented Jul 8, 2021

@agrohsje The failures seem to be fake similarly as reported in #29365

@agrohsje
Copy link

agrohsje commented Jul 8, 2021

Thanks @qliphy . Same is also true for 8_0:
#34361 (comment)

@agrohsje
Copy link

agrohsje commented Jul 8, 2021

+generators

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 8, 2021

+1

@cmsbuild cmsbuild merged commit 08058cc into cms-sw:CMSSW_9_4_X Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants