Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake warning. #3449

Merged
1 commit merged into from Apr 23, 2014
Merged

Remove fake warning. #3449

1 commit merged into from Apr 23, 2014

Conversation

ghost
Copy link

@ghost ghost commented Apr 23, 2014

Warnings are used as a way to detect issues with the build of cmssw, shouldn't be used as notification.

Warnings are used as a way to detect issues with the build of cmssw, shouldn't be used as notification.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Degano (Alessandro Degano) for CMSSW_6_2_X_SLHC.

Remove fake warning.

It involves the following packages:

SLHCUpgradeSimulations/L1CaloTrigger

The following packages do not have a category, yet:

SLHCUpgradeSimulations/L1CaloTrigger

@cmsbuild, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf
Copy link
Contributor

ktf commented Apr 23, 2014

Looks like there is also a new package added. Can you modify cmsbot to include it? L1 and Sim as categories, I imagine.

@ghost
Copy link
Author

ghost commented Apr 23, 2014

Done in cms-sw/cms-bot#57

@ghost
Copy link
Author

ghost commented Apr 23, 2014

@andersonjacob and @mark-grimes, I am bypassing signature as this is only a clean up of misused warnings.

ghost pushed a commit that referenced this pull request Apr 23, 2014
@ghost ghost merged commit c7252cb into cms-sw:CMSSW_6_2_X_SLHC Apr 23, 2014
@ghost ghost deleted the remove_fake_warnings_62XSLHC branch April 23, 2014 12:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants