-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add esConsumes to RecoMuon/MuonIsolation #34591
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34591/24147
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals RelVals
|
@cmsbuild please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
@smuzaffar
did somebody kill this manually? |
@slava77 , I do not see any thing killing these jobs, system logs on the VM ( where the job ran) also look good. I can restart the input relval test to see how it behaves |
Thanks for restarting. |
@smuzaffar about a half dozen of my PR tests run last night failed for the exact same reasons. |
@Dr15Jones , last night many relvals test jobs took over 3 hours ( https://cmssdt.cern.ch/jenkins/job/ib-run-pr-relvals/buildTimeTrend ) which is not normal. Normally these jobs take 60-80 mins, may be there was issue with EOS or network. |
@Dr15Jones , relvalinput test for this PR is again hanging . The jobs were timeout after 900s. You can do the following to reproduce it
|
@smuzaffar I've run the test as you suggested at FNAL and it passes just fine. It does take about 15 minutes to get to the first event. I attribute that to having to read the files trans-atlantically via Russia
|
@makortel |
So what I do not understand is this code change did NOT change any dependencies between modules as the check only looks at ED module dependencies, never ES modules. |
@smuzaffar it looks like a problem with CMSSW_12_0_X_2021-07-22-1700. If I look at the log for wf 11601.0 for step2 I see it takes 19 minutes to get to the first event:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bba74f/17155/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
Code compiles.