Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7_0_X Remove false dependency in DataFormats/TauReco to RecoVertex/VertexTools #3468

Merged
merged 2 commits into from May 20, 2014

Conversation

alja
Copy link
Contributor

@alja alja commented Apr 23, 2014

The change avoids pulling 30 new libraries in FWLite.

@alja alja changed the title Remove false dependency in DataFormats/TauReco to RecoVertex/VertexTools 7_0_X Remove false dependency in DataFormats/TauReco to RecoVertex/VertexTools Apr 23, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_0_X.

7_0_X Remove false dependency in DataFormats/TauReco to RecoVertex/VertexTools

It involves the following packages:

DataFormats/TauReco

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja
Copy link
Contributor Author

alja commented Apr 23, 2014

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 6, 2014

there is a knock-on effect
one dependence will be missing after this is removed.
@ktf Giulio, where was the fix that you put in?
Could you please resubmit it for 70X or/and include #3468 in it as well

@ktf
Copy link
Contributor

ktf commented May 6, 2014

Yes. It actually needs to be changed to FWCore/Common, not removed.

@slava77
Copy link
Contributor

slava77 commented May 15, 2014

Hi Giulio,
is it still pending for 70X or was it taken care of in a separate PR already?

@ktf
Copy link
Contributor

ktf commented May 15, 2014

Still pending. @alja can you please update this? Thanks.

@alja
Copy link
Contributor Author

alja commented May 15, 2014

@ktf I have pulled changes from official CMSSW_7_0_X branch. Hope this now works.

@alja
Copy link
Contributor Author

alja commented May 19, 2014

Build was without errors. Do you still want me to check?

@slava77
Copy link
Contributor

slava77 commented May 19, 2014

Hi Alja
build just finds objects in the release libraries. So, it's not a good test.
We need a change as in #3495 : add <use name="FWCore/Common"/> to DataFormats/TauReco/BuildFile.xml

@alja
Copy link
Contributor Author

alja commented May 19, 2014

I added the line in DataFormats/TauReco/BuildFile.xm.

@cmsbuild
Copy link
Contributor

Pull request #3468 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 20, 2014

+1

for #3468 8f25071
changes look as needed, the ultimate test is going to be a new IB

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 20, 2014
Fireworks -- Remove false dependency in  DataFormats/TauReco to RecoVertex/VertexTools
@ktf ktf merged commit 198ed0b into cms-sw:CMSSW_7_0_X May 20, 2014
@alja alja deleted the from-CMSSW_7_0_3 branch November 8, 2014 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants