-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal Validation/RecoTrack/python/plotting/plotting.py fix for division changes in py3 #34708
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34708/24342
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages:
@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Follow up to #34420, @makortel @davidlange6 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-056b1b/17376/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
While making MTV plots comparing multiple scenarios, hit a problem with floating point array indices. This PR provides a minimal fix which allows plotting to proceed. There are probably more cases like this, I did not audit the code for other examples.
PR validation:
Prior to this PR,
makeTrackValidationPlots.py --extended
of multiple DQM outputs to compare would fail with an error about floating point array indices. With this PR, the same command succeeds.