Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploading EventSetup conditions from multiple CUDA streams [11.3.x] #34731

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 2, 2021

PR description:

When multiple CUDA streams are trying to initialise the same EventSetup object, the first one to do so starts the asynchronous operations, and the others are supposed to wait for it to finish. However, code for recording the CUDA event was missing, so the other streams would find the default- constructed event, which is always "valid".

Adding the missing call to record the event fixes the problem.

PR validation:

See #34725 .

PR status:

Backport of #34725 to CMSSW_11_3_X.

When multiple CUDA streams are trying to initialise the same EventSetup object, the first one to do
so starts the asynchronous operations, and the others are supposed to wait for it to finish.
However, code for recording the CUDA event was missing, so the other streams would find the default-
constructed event, which is always "valid".

Adding the missing call to record the event fixes the problem.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_3_X.

It involves the following packages:

  • HeterogeneousCore/CUDACore (heterogeneous)

@makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 2, 2021

backport of #34725

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 2, 2021

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 2, 2021

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 2, 2021

+heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fb81f/17438/summary.html
COMMIT: 03b30c3
CMSSW: CMSSW_11_3_X_2021-08-01-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34731/17438/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2878314
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2878285
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Aug 4, 2021

+1
Successfully merged in master

@cmsbuild cmsbuild merged commit e606ae5 into cms-sw:CMSSW_11_3_X Aug 4, 2021
@fwyzard fwyzard deleted the CUDA_fix_concurrent_EventSetup_filling branch August 18, 2021 13:31
@fwyzard fwyzard restored the CUDA_fix_concurrent_EventSetup_filling branch August 19, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants