Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce memory order to avoid crash on Ampere [11.3.x] #34736

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 2, 2021

PR description:

Add missing memory fences to avoid crashes on Ampere (and potentially other) GPUs.

PR validation:

See #34386 .

####PR status:

Backport of #34386 .

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 2, 2021

backport of #34386

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 2, 2021

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 2, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_3_X.

It involves the following packages:

  • RecoPixelVertexing/PixelTriplets (reconstruction)

@perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0b01a/17443/summary.html
COMMIT: 113dba7
CMSSW: CMSSW_11_3_X_2021-08-01-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34736/17443/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2878314
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2878291
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@fwyzard fwyzard changed the title enforce memory order to avoid crash on Ampere enforce memory order to avoid crash on Ampere [11.3.x] Aug 4, 2021
@perrotta
Copy link
Contributor

perrotta commented Aug 4, 2021

urgent

@cmsbuild cmsbuild added the urgent label Aug 4, 2021
@slava77
Copy link
Contributor

slava77 commented Aug 4, 2021

+reconstruction

for #34736 113dba7

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 4, 2021

+1

@cmsbuild cmsbuild merged commit 8d0c868 into cms-sw:CMSSW_11_3_X Aug 4, 2021
@fwyzard fwyzard deleted the fenceforampere_113x branch August 18, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants