Run3-alca202X Add the treemaker for the new AlCaReco of HcalHBHEMuon

[bsunanda]

PR description:

Add the treemaker for the new AlCaReco of HcalHBHEMuon

PR validation:

Tested by running the new and old tree makers on corresponding AlCa o/p files

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35383/25474

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35383/25474/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35383/25474/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35383/25475

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Calibration/HcalAlCaRecoProducers (alca)
• Calibration/HcalCalibAlgos (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[tvami]

Hi @bsunanda I think these config files should be under test, only the _cfi and _cff files should be under python. Otherwise I have no comments, everything looks good to me

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f748d7/18860/summary.html
COMMIT: 0cf5d10
CMSSW: CMSSW_12_1_X_2021-09-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35383/18860/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[bsunanda]

@tvami the _cfi _cff are in the directory python while the cfg's are in test/python. These scripts are not compiled using "scram b" command. This is natural to create a subdirectory under test and put the cfg's there. We maintain this in a number of packages where we keep large number of cfg's. It is good that all test cfg's are kept separate from other test codes. If you are worried of the name "test/python" we can rename it as "test/cfgs" - but the first name is certainly more preferable.

[tvami]

Ahhh it slipped my attention that it was indeed under /test, but there is a subdirectory called python there. I guess that should be fine, although it's a bit misleading. Let's see what the release managers say about this structure @perrotta @qliphy

[tvami]

+alca

• let's see what the release managers say about this Run3-alca202X Add the treemaker for the new AlCaReco of HcalHBHEMuon #35383 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• I see no issues in using a \python subdirectory under \test

[makortel]

This macro should not be defined by default.

[bsunanda]

Sorry it was left out by mistake. We shall correct this.

________________________________ From: Matti Kortelainen ***@***.*** Sent: 29 October 2021 17:12 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-alca202X Add the treemaker for the new AlCaReco of HcalHBHEMuon (#35383) @makortel commented on this pull request.

________________________________ In Calibration/HcalCalibAlgos/plugins/HcalHBHENewMuonAnalyzer.cc<#35383 (comment)>:

+#include "TPRegexp.h"

+ +// user include files +#include "FWCore/Framework/interface/Frameworkfwd.h" +#include "FWCore/Framework/interface/one/EDAnalyzer.h" +#include "FWCore/Framework/interface/Event.h" +#include "FWCore/MessageLogger/interface/MessageLogger.h" +#include "FWCore/ParameterSet/interface/ParameterSet.h" +#include "FWCore/ParameterSet/interface/ConfigurationDescriptions.h" +#include "FWCore/ServiceRegistry/interface/Service.h" +#include "FWCore/Common/interface/TriggerNames.h" +#include "CommonTools/UtilAlgos/interface/TFileService.h" + +#include "DataFormats/HcalCalibObjects/interface/HcalHBHEMuonVariables.h" + +#define EDM_ML_DEBUG This macro should not be defined by default. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#35383 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOUTNX77BOXKICQLFELUJK2XXANCNFSM5ETTJIHQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.