Set equivalence of first/last bx labels used by different subsystems in ECAL DQM

[alejands]

PR description:

A bug was discovered by ECAL DAQ in which the labeling conventions for the first/last bunch crossing are different depending on the subsystem: http://cmsonline.cern.ch/cms-elog/1123223

TCDS always labels this bx as 3564, while other subsystems label it as 0. This was leading to a DQM integrity error plot being mistakenly filled.

We have set these values so the bx labels are treated as the same in this scope and avoid incorrectly filling DQM integrity error plots.

PR validation:

The ECAL DQM code was run on an offending dataset and the fake integrity errors disappeared. We also confirmed the results with ECAL DAQ.

Backport to CMSSW_12_0_X provided here: #35674

Suggestion made in the backport PR here #35674 (comment) was made after this PR was merged, quick fix in master done here #35725

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35661/25932

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35661/25932/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35661/25932/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[jfernan2]

test parameters

• addpkg = DQM/Integration

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35661/25934

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @alejands (Alejandro Sanchez) for master.

It involves the following packages:

• DQM/EcalMonitorTasks (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74ebdb/19610/summary.html
COMMIT: 71e5474
CMSSW: CMSSW_12_1_X_2021-10-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35661/19610/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2796791
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2796768
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[jfernan2]

Hi @alejands
Could you provide a backport of this PR to 12_0_X in order to include it in Online DQM at P5?
Thanks

[alejands]

Hi @jfernan2

I've submitted a backport here: #35674

[jfernan2]

+1
Backport tested in Online DQM at P5

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1