-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set equivalence of first/last bx labels used by different subsystems in ECAL DQM #35661
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35661/25932
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
test parameters
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35661/25934
|
A new Pull Request was created by @alejands (Alejandro Sanchez) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74ebdb/19610/summary.html Comparison SummarySummary:
|
Hi @alejands |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
A bug was discovered by ECAL DAQ in which the labeling conventions for the first/last bunch crossing are different depending on the subsystem: http://cmsonline.cern.ch/cms-elog/1123223
TCDS always labels this bx as 3564, while other subsystems label it as 0. This was leading to a DQM integrity error plot being mistakenly filled.
We have set these values so the bx labels are treated as the same in this scope and avoid incorrectly filling DQM integrity error plots.
PR validation:
The ECAL DQM code was run on an offending dataset and the fake integrity errors disappeared. We also confirmed the results with ECAL DAQ.
Backport to CMSSW_12_0_X provided here: #35674
Suggestion made in the backport PR here #35674 (comment) was made after this PR was merged, quick fix in master done here #35725