Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update customisePixelL1ClusterThresholdForRun2Input to adjust also the GPU producer [12.1.x] #35902

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 29, 2021

PR description:

Update customisePixelL1ClusterThresholdForRun2Input() to adjust also the GPU producer with the Run 2 settings.

PR validation:

None.

PR backport status:

Backport of #35901 to 12.1.x .

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2021

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 29, 2021

backport #35901

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 29, 2021

type bugfix

@fwyzard fwyzard force-pushed the fix_customiseHCALFor2018Input_121x branch from 8c1a266 to cda3168 Compare October 29, 2021 16:02
@cmsbuild
Copy link
Contributor

Pull request #35902 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 29, 2021

please test

@missirol
Copy link
Contributor

please abort

@missirol
Copy link
Contributor

test parameters:

@missirol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa36c2/20093/summary.html
COMMIT: cda3168
CMSSW: CMSSW_12_1_X_2021-10-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35902/20093/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901412
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

  • despite the label, this PR did not really require any externals
    (the other PR is not merged yet; it provides an unrelated fix for a timeout in a PR test)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 1, 2021

+1

@cmsbuild cmsbuild merged commit c6b9967 into cms-sw:CMSSW_12_1_X Nov 1, 2021
@fwyzard fwyzard deleted the fix_customiseHCALFor2018Input_121x branch November 23, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants