-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand tracker-driven coverage for electron seeds; jetCore mitigation (bp of #35892) #35958
expand tracker-driven coverage for electron seeds; jetCore mitigation (bp of #35892) #35958
Conversation
A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_12_1_X. It involves the following packages:
@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
backport of #35892 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50d44a/20194/summary.html Comparison SummarySummary:
|
@swagata87 |
Hi Slava,
I am a bit lost in new and old plans of 12_1 and 12_2 of the next campaign of sample production. |
Hi Swagata, Thank you for the clarification on the short term plans
the description for this sounds like the plan for what's currently called 12_2 release (recall that the indexing/naming of the releases changed about a week ago). @rappoccio please check/confirm about large physics reco samples in 12_2 (vs not in 12_1). |
tagging Linda |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Thank you @slava77 |
Just to reiterate what we discussed during the meeting: If it's really only a day or two, we can wait to include it in 12.1.0. |
The master version of this PR, #35892, was just merged. Unless unexpected issues will show up from the nightly builds, tomorrow we can merge this PR in 12_1_X and start building 12_1_0 From the discussions in the github thread of #35892 it must be clear that this PR will bring
and the full extent of what above can only be assessed with a complete validation. According to the declared purposed of 12_1_0 I see no issue in merging it, even if the exact impact on egamma objects cannot be quantified yet. I'm just pointing it out here in case it was not evident to anybody. |
+1
|
Changes in this PR were motivated to mitigate the situation with tracks reconstructed multiple times, one of them jet core after introduction of mkFit to the non-jetCore iterations.
This was presented in TRK POG on Nov 1: https://indico.cern.ch/event/1092090/#3-interplay-in-high-pt-electro
see more details in #35892