[12.1.X] Update of mkFit as in 12_2_0 (backport of PR #35974)

[mmasciov]

PR description:

Backport of PR #35974 to 12_1_X, together with cms-sw/cmsdist#7444.
The reason for the backport is to ensure that data reprocessing makes use of the same mkFit developments available in 12_2_X.

It requires cms-sw/cmsdist#7444.

PR validation:

Please refer to PR #35974.

[cmsbuild]

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for CMSSW_12_1_X.

It involves the following packages:

• RecoTracker/MkFit (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Update mkFit for CMSSW_12_2_0 #35974

[tvami]

@cmsbuild , please test with cms-sw/cmsdist#7444

[tvami]

backport of #35974

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d822cd/20434/summary.html
COMMIT: 418ac2f
CMSSW: CMSSW_12_1_X_2021-11-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36075/20434/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 22814 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901440
• DQMHistoTests: Total failures: 33897
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 2867515
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.105 KiB( 41 files compared)
• DQMHistoSizes: changed ( 136.793 ): -0.031 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 136.874 ): -0.074 KiB JetMET/SUSYDQM
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: found differences in 1 / 41 workflows

[tvami]

urgent

• TkAlignment would like to test mkFit with a rereco (in 12_1_X) so we'd need this in asap

[jpata]

Do we need a formal confirmation that changing the reco results in 12_1_X is OK (that no sample submission has been done)?

[qliphy]

Do we need a formal confirmation that changing the reco results in 12_1_X is OK (that no sample submission has been done)?

@rappoccio @cms-sw/pdmv-l2 may confirm on this.
Anyway we don't have sample production with 12_1_X, which was released last week.

[jpata]

Anyway we don't have sample production with 12_1_X, which was released last week.

Thank you, that's what I thought but I wasn't sure. Approving this just now.

[jpata]

+reconstruction

• exact backport of Update mkFit for CMSSW_12_2_0 #35974
• physics changes in tracks and downstream quantities observed and are NOT protected with a modifier (this should be fine, since there is no sample production with 12_1 yet)
• requires [12.1.X] Update of mkFit release and configuration (backport of PRs #7427 + #7443) cmsdist#7444

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1