Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make HLT use "schedule" [12.1.X] #36252

Merged
merged 2 commits into from Nov 26, 2021

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Nov 25, 2021

backport of #35858 #36019

TSG would like to backport #35858 to 12_1_X in view of an upcoming update of ConfDB.

(#36019 needs to be backported with it as well, to maintain a unit test functional.)

The goal is to ease the work of HLT developers, making 12_1_X behave the same as 12_2_X in terms of the name of the cms.Schedule provided by HLT configs.

More information can be found in #35842 and #36237.

This PR is merely technical, and no changes are expected.

PR description:

Copied from the description of #35858:

The first step towards the resolution of #35842 could be the renaming of HLTSchedule to schedule, using one of the standard HLT customisation functions. This PR is an attempt at that.

The final solution will have to come eventually with a change in ConfDB.

Standalone configs in test/ that use/assume HLTSchedule have been ignored for the moment (except for one that I know is used used to run in unit tests).

Merely technical; no changes expected.

PR validation:

addOnTests and unit tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#35858 #36019

Goal: user support for HLT development in 12_1_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 25, 2021

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_1_X.

It involves the following packages:

  • Configuration/Applications (operations)
  • HLTrigger/Configuration (hlt)
  • RecoTauTag/HLTProducers (hlt)
  • SLHCUpgradeSimulations/Geometry (geometry, upgrade)

@perrotta, @Martin-Grunewald, @civanch, @Dr15Jones, @missirol, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@silviodonato, @Martin-Grunewald, @makortel, @azotz, @mbluj, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

backport of #35858

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-375017/20773/summary.html
COMMIT: 7ef40fa
CMSSW: CMSSW_12_1_X_2021-11-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36252/20773/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2901411
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@srimanob
Copy link
Contributor

+Upgrade

For the upgrade part, backport of #36019

@cvuosalo
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants