Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim LL fix missing ! in beam pipe radius check. #36324

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

sbein
Copy link
Contributor

@sbein sbein commented Dec 1, 2021

PR description:

A typo was introduced when implementing @perrotta's suggestion:
#36122

Thanks to Carlos Cid for spotting it almost instantly.

@sbein
Copy link
Contributor Author

sbein commented Dec 1, 2021

+1

@perrotta
Copy link
Contributor

perrotta commented Dec 1, 2021

Good spot. Let merge it at once, no need to test

@perrotta
Copy link
Contributor

perrotta commented Dec 1, 2021

code-checks

@perrotta
Copy link
Contributor

perrotta commented Dec 1, 2021

ping bot

@perrotta
Copy link
Contributor

perrotta commented Dec 1, 2021

merge

@perrotta
Copy link
Contributor

perrotta commented Dec 1, 2021

@smuzaffar , it seems thst everything got stuck here.
The intention is to merge this (simple) PR: can you help with it?

@smuzaffar
Copy link
Contributor

I am checking

@smuzaffar
Copy link
Contributor

code checks are running https://cmssdt.cern.ch/jenkins/job/run-pr-code-checks/27067/console , once done then bot will merge this PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36324/27067

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

A new Pull Request was created by @sbein (Sam Bein) for master.

It involves the following packages:

  • FastSimulation/SimplifiedGeometryPropagator (fastsim)

can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild cmsbuild merged commit a222dc9 into cms-sw:master Dec 1, 2021
@perrotta
Copy link
Contributor

perrotta commented Dec 1, 2021

Thank you @smuzaffar !

@sbein
Copy link
Contributor Author

sbein commented Dec 1, 2021

Thank you @smuzaffar, @perrotta!

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5586ba/20914/summary.html
COMMIT: aa324b0
CMSSW: CMSSW_12_2_X_2021-12-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36324/20914/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3041955
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3041927
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
  • Checked 175 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants