Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB output migration of RPCReadOutMapBuilder #36367

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Dec 5, 2021

PR description:

Part of the migration for cms-AlCaDB/AlCaTools#28

PR validation:

Code compiles, scramv1 b runtests runs

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@tvami
Copy link
Contributor Author

tvami commented Dec 5, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36367/27134

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2021

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • CondFormats/RPCObjects (db, alca)

@ggovi, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ed2da/21001/summary.html
COMMIT: 1a48c79
CMSSW: CMSSW_12_2_X_2021-12-05-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36367/21001/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3041955
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3041921
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 40 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 175 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@ggovi
Copy link
Contributor

ggovi commented Dec 6, 2021

+db

@malbouis
Copy link
Contributor

malbouis commented Dec 6, 2021

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar modified the milestones: CMSSW_12_2_X, CMSSW_12_3_X Dec 6, 2021
@qliphy
Copy link
Contributor

qliphy commented Dec 7, 2021

+1

@cmsbuild cmsbuild merged commit 963a9c2 into cms-sw:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants