Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_2_X] Add VtxSmearing scenario for 2021 PilotBeams #36440

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #36439

This PR adds the realistic vertex smearing scenario for 2021 PilotBeams data.

  • The BeamSpot parameters are extracted from run 346512 (Fill 7531) using the ExpressPhysics FEVT dataset, the legacy BS workflow, and refitting trks and PVs with the latest and greatest TkAlignment conditions.
  • The BPIX barycenter comes from this twiki

This will be needed for MC production to be analyzed with the PilotBeams 2021 data re-reco.

PR validation:

Code compiles

Backport:

Backport of #36439

FYI @mmusich @dzuolo @lguzzi

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

A new Pull Request was created by @francescobrivio for CMSSW_12_2_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • IOMC/EventVertexGenerators (simulation)

@perrotta, @civanch, @mdhildreth, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @jan-kaspar, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

backport of #36439

@francescobrivio
Copy link
Contributor Author

code-checks

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36440/27280

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d58101/21144/summary.html
COMMIT: 27e81c1
CMSSW: CMSSW_12_2_X_2021-12-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36440/21144/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3250580
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Dec 10, 2021

+1

@francescobrivio
Copy link
Contributor Author

@perrotta @qliphy this is basically fully signed (except your signatures 😄), please consider merging at your convenience.

@francescobrivio
Copy link
Contributor Author

@perrotta @qliphy this is basically fully signed (except your signatures 😄), please consider merging at your convenience.

@perrotta @qliphy Master PR has been merged since 2 days now, any specific reason why this backport is not merged yet?

@perrotta
Copy link
Contributor

@perrotta @qliphy Master PR has been merged since 2 days now, any specific reason why this backport is not merged yet?

Weekend, maybe?

@perrotta
Copy link
Contributor

+1

  • VtxSmearing scenario for 2021 PilotBeams made available for possible re-reco

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit bb90c8c into cms-sw:CMSSW_12_2_X Dec 12, 2021
@francescobrivio francescobrivio deleted the alca-VtxSmearing_12_2_X branch December 13, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants