add process modifier to enable x-talk in Phase-2 InnerTracker pixels

[emiglior]

PR description:

This PR concerns the phase-2 upgrade.
This PR introduces a process modifier to activate cross-talk in the phase-2 Inner Tracker 25x100 um planar pixels.
For the time being, the process modifier is meant to be used only as a command line option of cmsDriver.py for requesting RelVals to study the impact of cross-talk.
Workflows in upgradeWorkflowComponents.py are not affected by this process modifier.
As no mitigation of cross-talk is currently implemented in the local reco of phase-2 Inner Tracker, we plan to request RelVals up to the DIGI step.

PR validation:

• Checked runTheMatrix workflows run without errors
• Checked running w/f 36200.0 without and with the "--procModifier enableXTalkInPhase2Pixel" option that the distribution of DIGI in the InnerTracker changes as expected

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport

@suchandradutta @AndreasAlbert

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37028/28456

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @emiglior (Ernesto Migliore) for master.

It involves the following packages:

• Configuration/ProcessModifiers (operations)
• SimTracker/SiPhase2Digitizer (upgrade, simulation)

@perrotta, @civanch, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98c3fa/22577/summary.html
COMMIT: 8b11eb1
CMSSW: CMSSW_12_3_X_2022-02-22-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37028/22577/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3965143
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3965119
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emiglior]

@OzAmram FYI

[civanch]

@emiglior , is it possible to edit the title: ph2 -> Phase-2 ?

[civanch]

+1

[emiglior]

Please assign this PR to upgrade and test it.
As the process modifier is supposed to have no effect on the existing w/f, any w/f with premixing should be ok for the test,
e.g. 39634.99

[srimanob]

Hi @emiglior
The PR test is done with D77 premixing
35234.999_TTbar_14TeV+2026D77PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/

Is this not enough?

[srimanob]

test parameters:

• workflows = 39634.999
• relvals_opt = --what upgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix

[srimanob]

@cmsbuild please test

[srimanob]

By the way, testing with 39634.99, we will not have a comparison.

[emiglior]

@srimanob as it should have no effects on the existing w/f, please feel free to use any other process with preMixing as benchmark

[mmusich]

Please assign this PR to upgrade and test it.
As the process modifier is supposed to have no effect on the existing w/f, any w/f with premixing should be ok for the test,
e.g. 39634.99

I am a bit confused by these requests:

• the PR is already assigned to upgrade
• as there is no wf in the matrix that makes use of the modifier introduced here, what is the purpose of asking a specific test? The regular matrix was already tested successfully here

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98c3fa/22633/summary.html
COMMIT: 8b11eb1
CMSSW: CMSSW_12_3_X_2022-02-23-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37028/22633/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 39634.999

----- Begin Fatal Exception 24-Feb-2022 09:36:14 CET-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

[srimanob]

test parameters:

[srimanob]

I agree with @mmusich as I asked if 35234.999 is not good enough. I will retrigger the standard test to get green light, and then I will sign the PR.

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98c3fa/22635/summary.html
COMMIT: 8b11eb1
CMSSW: CMSSW_12_3_X_2022-02-23-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37028/22635/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 4001143
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4001119
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

This PR introduces proc modifier which is not turned on by default. No change is expected, and not seen in the PR test.

[perrotta]

+operations

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1